chrome/browser/extensions/extension_management_internal.cc - Issue 1301883002: Revert of base: Remove using:: declaration from version.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management_internal.cc

Issue 1301883002: Revert of base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_management_internal.cc

diff --git a/chrome/browser/extensions/extension_management_internal.cc b/chrome/browser/extensions/extension_management_internal.cc

index 0e78408368bc4920a72365dd900dc5fcf601b37d..df1bbe7e51ee722b29e4dffcfba505296e69f6e2 100644

--- a/chrome/browser/extensions/extension_management_internal.cc

+++ b/chrome/browser/extensions/extension_management_internal.cc

@@ -136,7 +136,7 @@

schema_constants::kMinimumVersionRequired,

&minimum_version_required_str)) {

scoped_ptr<base::Version> version(

- new base::Version(minimum_version_required_str));

+ new Version(minimum_version_required_str));

// We accept a general version string here. Note that count of components in

// version string of extensions is limited to 4.

if (!version->IsValid())

« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »