Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1293113002: Remove property loads from js builtins objects from runtime. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove property loads from js builtins objects from runtime. R=cbruni@chromium.org Committed: https://crrev.com/40f6e80d22d2e146b781aa661b76087ab9a492c4 Cr-Commit-Position: refs/heads/master@{#30199} Committed: https://crrev.com/f22d0f205031054a5f3116e052c81ae85741e8e0 Cr-Commit-Position: refs/heads/master@{#30209}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix stack overflow during bootstrapping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -75 lines) Patch
M src/api.cc View 7 chunks +36 lines, -40 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 1 1 chunk +11 lines, -9 lines 0 comments Download
M src/messages.js View 7 chunks +17 lines, -21 lines 0 comments Download
M src/v8natives.js View 3 chunks +2 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (6 generated)
Yang
5 years, 4 months ago (2015-08-17 13:06:25 UTC) #1
Camillo Bruni
lgtm https://codereview.chromium.org/1293113002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1293113002/diff/1/src/api.cc#newcode2285 src/api.cc:2285: !i::Execution::Call(isolate, fun, undefined, arraysize(args), args) Would it make ...
5 years, 4 months ago (2015-08-17 14:43:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293113002/1
5 years, 4 months ago (2015-08-17 14:43:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 15:08:26 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/40f6e80d22d2e146b781aa661b76087ab9a492c4 Cr-Commit-Position: refs/heads/master@{#30199}
5 years, 4 months ago (2015-08-17 15:08:44 UTC) #6
Michael Hablich
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1294123002/ by hablich@chromium.org. ...
5 years, 4 months ago (2015-08-17 15:31:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293113002/20001
5 years, 4 months ago (2015-08-18 07:20:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4980)
5 years, 4 months ago (2015-08-18 07:26:09 UTC) #12
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-18 07:41:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293113002/20001
5 years, 4 months ago (2015-08-18 07:42:08 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 07:48:18 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f22d0f205031054a5f3116e052c81ae85741e8e0 Cr-Commit-Position: refs/heads/master@{#30209}
5 years, 4 months ago (2015-08-18 07:48:32 UTC) #18
Yang
5 years, 4 months ago (2015-08-18 09:37:14 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1297803003/ by yangguo@chromium.org.

The reason for reverting is: Still failures in debug-isolates tests.

Powered by Google App Engine
This is Rietveld 408576698