Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1314543004: Message formatting: handle unexpected case of failing property lookup. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Camillo Bruni
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Message formatting: handle unexpected case of failing property lookup. R=cbruni@chromium.org BUG=chromium:523308 LOG=N Committed: https://crrev.com/24544698efa7e52e23c4cd270ba090c83cf47f9b Cr-Commit-Position: refs/heads/master@{#30330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/messages.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-523308.js View 1 chunk +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-24 11:42:50 UTC) #1
Camillo Bruni
lgtm
5 years, 4 months ago (2015-08-24 13:17:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314543004/1
5 years, 4 months ago (2015-08-24 13:18:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 13:40:25 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 13:40:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24544698efa7e52e23c4cd270ba090c83cf47f9b
Cr-Commit-Position: refs/heads/master@{#30330}

Powered by Google App Engine
This is Rietveld 408576698