Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1287203006: Native context: Fix issue when running prologue.js before runtime.js (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native context: Fix issue when running prologue.js before runtime.js %InstallFunctionsFromArray is not entirely equivalent to the old InstallFunctions implementation, which causes gc stress failures. TBR=mvstanton@chromium.org Committed: https://crrev.com/c01f419e1ac16551772c338446839d7b1cf83f4d Cr-Commit-Position: refs/heads/master@{#30220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -59 lines) Patch
M src/prologue.js View 7 chunks +34 lines, -22 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -36 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-18 12:36:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287203006/1
5 years, 4 months ago (2015-08-18 12:36:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 13:08:11 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c01f419e1ac16551772c338446839d7b1cf83f4d Cr-Commit-Position: refs/heads/master@{#30220}
5 years, 4 months ago (2015-08-18 13:08:30 UTC) #5
mvstanton
5 years, 4 months ago (2015-08-19 00:18:42 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698