Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1300333003: Introduce SharedFunctionInfo::Iterator and Script::Iterator. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce SharedFunctionInfo::Iterator and Script::Iterator. R=mvstanton@chromium.org Committed: https://crrev.com/4c5efa996147d84f5d1f3b79ecce5fa2ff2c2cde Cr-Commit-Position: refs/heads/master@{#30283}

Patch Set 1 #

Patch Set 2 : use iterator for all weak fixed array iterations #

Patch Set 3 : fix #

Patch Set 4 : small fix #

Patch Set 5 : rebase #

Patch Set 6 : fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -49 lines) Patch
M src/debug/debug.cc View 1 2 3 3 chunks +12 lines, -12 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 1 chunk +3 lines, -6 lines 0 comments Download
M src/objects.h View 1 2 3 3 chunks +46 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 4 chunks +56 lines, -24 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 3 4 2 chunks +4 lines, -7 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 5 1 chunk +62 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 34 (17 generated)
Yang
5 years, 4 months ago (2015-08-20 11:36:20 UTC) #1
Yang
Added an iterator for WeakFixedArray, so that we can use it whenever we want to ...
5 years, 4 months ago (2015-08-20 12:59:04 UTC) #3
mvstanton
lgtm
5 years, 4 months ago (2015-08-20 13:03:08 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300333003/20001
5 years, 4 months ago (2015-08-20 13:34:45 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/8841)
5 years, 4 months ago (2015-08-20 13:52:32 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300333003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300333003/40001
5 years, 4 months ago (2015-08-20 13:58:51 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/3477)
5 years, 4 months ago (2015-08-20 14:19:35 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300333003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300333003/50001
5 years, 4 months ago (2015-08-21 06:55:43 UTC) #16
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-21 07:06:00 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-21 07:20:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300333003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300333003/50001
5 years, 4 months ago (2015-08-21 07:22:20 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5089)
5 years, 4 months ago (2015-08-21 07:24:04 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300333003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300333003/70001
5 years, 4 months ago (2015-08-21 07:36:51 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/7029) v8_linux64_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 4 months ago (2015-08-21 07:40:26 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300333003/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300333003/90001
5 years, 4 months ago (2015-08-21 07:47:22 UTC) #32
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 4 months ago (2015-08-21 08:12:17 UTC) #33
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 08:12:35 UTC) #34
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4c5efa996147d84f5d1f3b79ecce5fa2ff2c2cde
Cr-Commit-Position: refs/heads/master@{#30283}

Powered by Google App Engine
This is Rietveld 408576698