Issue 1312763002: Deserializer: flush code cache while code pointers are still valid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1312763002: Deserializer: flush code cache while code pointers are still valid. (Closed)

Created:
5 years, 4 months ago by Yang

Modified:
5 years, 3 months ago

Reviewers:
Michael Lippautz

CC:
v8-dev, Yang

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Deserializer: flush code cache while code pointers are still valid. Omitting test case because it would be brittle and become useless soon. R=mlippautz@chromium.org BUG=chromium:523453 LOG=N Committed: https://crrev.com/e642fde41408bb744b26b3de2096103f9d5d40b6 Cr-Commit-Position: refs/heads/master@{#30331}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -14 lines)			Patch
	M	src/snapshot/serialize.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	src/snapshot/serialize.cc	View		5 chunks	+14 lines, -12 lines	0 comments	Download

Depends on Patchset:

Issue 1293113002 Patch 20001

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312763002/1

5 years, 3 months ago (2015-08-24 14:24:51 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-08-24 14:49:39 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e642fde41408bb744b26b3de2096103f9d5d40b6
Cr-Commit-Position: refs/heads/master@{#30331}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages