Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Issue 1297273005: Keep track of script objects in a weak fixed array. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Keep track of script objects in a weak fixed array. We need this for the debugger and for future changes that need to find all shared function infos (through scripts). R=mvstanton@chromium.org Committed: https://crrev.com/3ead18974d1f4f2b48076ba6e3762cec855b8f1f Cr-Commit-Position: refs/heads/master@{#30264}

Patch Set 1 #

Patch Set 2 : do not remove gc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -171 lines) Patch
M src/debug/debug.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/debug/debug.cc View 1 5 chunks +16 lines, -79 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -21 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (6 generated)
Yang
5 years, 4 months ago (2015-08-19 14:02:12 UTC) #1
mvstanton
Hey, that is very nice :). LGTM.
5 years, 4 months ago (2015-08-19 14:06:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297273005/1
5 years, 4 months ago (2015-08-19 14:07:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5038)
5 years, 4 months ago (2015-08-19 14:11:55 UTC) #6
mvstanton
Hi Michael, can you have a look at this one too?
5 years, 4 months ago (2015-08-19 14:19:13 UTC) #8
Hannes Payer (out of office)
heap: lgtm
5 years, 4 months ago (2015-08-19 14:35:44 UTC) #10
Michael Lippautz
lgtm
5 years, 4 months ago (2015-08-19 14:44:24 UTC) #11
Michael Lippautz
On 2015/08/19 14:35:44, Hannes Payer wrote: > heap: lgtm train internet....
5 years, 4 months ago (2015-08-19 14:52:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297273005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297273005/20001
5 years, 4 months ago (2015-08-20 07:32:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-20 08:04:48 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 08:05:00 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ead18974d1f4f2b48076ba6e3762cec855b8f1f
Cr-Commit-Position: refs/heads/master@{#30264}

Powered by Google App Engine
This is Rietveld 408576698