Issue 1310213002: Debugger: use correct position for for-next expression statement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1310213002: Debugger: use correct position for for-next expression statement. (Closed)

Created:
5 years, 4 months ago by Yang

Modified:
5 years, 4 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Debugger: use correct position for for-next expression statement. R=rossberg@chromium.org BUG=chromium:523543 LOG=N Committed: https://crrev.com/e8ce7acf538d61305775beb4df12b8e75f7e1416 Cr-Commit-Position: refs/heads/master@{#30328}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -7 lines)			Patch
M	src/parser.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/mjsunit/es6/debug-stepnext-for.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/es6/regress/regress-468661.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1293113002 Patch 20001

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310213002/1

5 years, 4 months ago (2015-08-24 12:43:20 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-24 13:08:30 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e8ce7acf538d61305775beb4df12b8e75f7e1416
Cr-Commit-Position: refs/heads/master@{#30328}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages