Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 1300363002: Fix bug in Code::VerifyRecompiledCode. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bug in Code::VerifyRecompiledCode. The code should do what the comment says :) R=mstarzinger@chromium.org BUG=chromium:522895 LOG=N Committed: https://crrev.com/a683f83dec0fcd1a89a59248a7f805f8aaeafb2f Cr-Commit-Position: refs/heads/master@{#30278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-522895.js View 1 chunk +22 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
Yang
5 years, 4 months ago (2015-08-20 13:56:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300363002/1
5 years, 4 months ago (2015-08-20 13:56:24 UTC) #3
Michael Starzinger
LGTM. Somehow the compiler seems to ignore all our comments. :)
5 years, 4 months ago (2015-08-20 13:57:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-20 14:53:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300363002/1
5 years, 4 months ago (2015-08-20 17:18:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 17:19:49 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 17:20:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a683f83dec0fcd1a89a59248a7f805f8aaeafb2f
Cr-Commit-Position: refs/heads/master@{#30278}

Powered by Google App Engine
This is Rietveld 408576698