Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1309673003: Small MessageLocation related refactoring. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Camillo Bruni
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Small MessageLocation related refactoring. R=cbruni@chromium.org Committed: https://crrev.com/1cdcae94c199a450110a776edf65fd1fea700459 Cr-Commit-Position: refs/heads/master@{#30305}

Patch Set 1 #

Total comments: 1

Patch Set 2 : keep old default values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -32 lines) Patch
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 6 chunks +13 lines, -19 lines 0 comments Download
M src/messages.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/messages.cc View 1 1 chunk +11 lines, -8 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Yang
5 years, 4 months ago (2015-08-21 09:50:54 UTC) #1
Camillo Bruni
lgtm https://codereview.chromium.org/1309673003/diff/1/src/messages.cc File src/messages.cc (right): https://codereview.chromium.org/1309673003/diff/1/src/messages.cc#newcode49 src/messages.cc:49: script_handle = Script::GetWrapper(isolate->factory()->empty_script()); The case used to default ...
5 years, 4 months ago (2015-08-21 12:12:21 UTC) #2
Yang
On 2015/08/21 12:12:21, cbruni wrote: > lgtm > > https://codereview.chromium.org/1309673003/diff/1/src/messages.cc > File src/messages.cc (right): > ...
5 years, 4 months ago (2015-08-21 12:45:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309673003/20001
5 years, 4 months ago (2015-08-21 12:47:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-21 13:18:59 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 13:19:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1cdcae94c199a450110a776edf65fd1fea700459
Cr-Commit-Position: refs/heads/master@{#30305}

Powered by Google App Engine
This is Rietveld 408576698