Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1285133009: Native context: do not hold onto helper functions on the utils object. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Camillo Bruni
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native context: do not hold onto helper functions on the utils object. This is to avoid holding onto the function context of prologue.js. R=cbruni@chromium.org Committed: https://crrev.com/55a2f5a50af58f8417f5a92a1c04ad550ed3a01b Cr-Commit-Position: refs/heads/master@{#30246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/i18n.js View 12 chunks +14 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-19 08:54:44 UTC) #1
Camillo Bruni
lgtm
5 years, 4 months ago (2015-08-19 10:30:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285133009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285133009/1
5 years, 4 months ago (2015-08-19 10:46:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 11:30:26 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 11:30:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55a2f5a50af58f8417f5a92a1c04ad550ed3a01b
Cr-Commit-Position: refs/heads/master@{#30246}

Powered by Google App Engine
This is Rietveld 408576698