Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307963002: Native context: alpha sort slots and remove boilerplate. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native context: alpha sort slots and remove boilerplate. R=mstarzinger@chromium.org Committed: https://crrev.com/38d46c037288999043080b006756cdc76f2d262b Cr-Commit-Position: refs/heads/master@{#30319}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -257 lines) Patch
M include/v8.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/ast-value-factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 2 chunks +8 lines, -76 lines 0 comments Download
M src/collection.js View 1 chunk +9 lines, -9 lines 0 comments Download
M src/contexts.h View 1 1 chunk +129 lines, -123 lines 0 comments Download
M src/date.js View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 1 chunk +15 lines, -15 lines 0 comments Download
M src/object-observe.js View 1 chunk +7 lines, -7 lines 0 comments Download
M src/promise.js View 1 chunk +8 lines, -7 lines 0 comments Download
M src/proxy.js View 1 chunk +4 lines, -4 lines 0 comments Download
M src/runtime.js View 1 chunk +4 lines, -4 lines 0 comments Download
M src/v8natives.js View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1293113002 Patch 20001

Messages

Total messages: 12 (4 generated)
Yang
5 years, 4 months ago (2015-08-21 13:37:35 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307963002/1
5 years, 4 months ago (2015-08-21 13:46:52 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-21 14:16:33 UTC) #5
Michael Starzinger
LGTM, just a naming suggestion. https://codereview.chromium.org/1307963002/diff/1/src/contexts.h File src/contexts.h (right): https://codereview.chromium.org/1307963002/diff/1/src/contexts.h#newcode76 src/contexts.h:76: #define IMPORTED_NATIVES(V) \ nit: ...
5 years, 4 months ago (2015-08-21 15:51:32 UTC) #6
Yang
On 2015/08/21 15:51:32, Michael Starzinger wrote: > LGTM, just a naming suggestion. > > https://codereview.chromium.org/1307963002/diff/1/src/contexts.h ...
5 years, 4 months ago (2015-08-24 06:50:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307963002/20001
5 years, 4 months ago (2015-08-24 06:50:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-24 07:15:06 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 07:15:25 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/38d46c037288999043080b006756cdc76f2d262b
Cr-Commit-Position: refs/heads/master@{#30319}

Powered by Google App Engine
This is Rietveld 408576698