Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1281953003: Revert of [Oilpan] Migrate classes under module/webgl onto oilpan heap (Closed)

Created:
5 years, 4 months ago by hans
Modified:
5 years, 4 months ago
CC:
blink-reviews, vivekg, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [Oilpan] Migrate classes under module/webgl onto oilpan heap (patchset #13 id:240001 of https://codereview.chromium.org/1234883002/ ) Reason for revert: This caused blink-gc plugin errors on all Win/Clang builders. See e.g. http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/2402 Original issue's description: > [Oilpan] Migrate classes under module/webgl onto oilpan heap > > > Following document reports the effect of this CL on performance and memory usages. > https://docs.google.com/document/d/1QUDGL5a2wBZVyUrzlGjzKFe1sQgOOvm6gNhB1B7VRoE/edit?usp=sharing > > > BUG=497662 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200298 TBR=oilpan-reviews@chromium.org,kbr@chromium.org,bajones@chromium.org,junov@chromium.org,zmo@chromium.org,sigbjornf@opera.com,haraken@chromium.org,peria@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497662 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+626 lines, -460 lines) Patch
M Source/bindings/modules/v8/WebGLAny.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/WebGLAny.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/ANGLEInstancedArrays.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/ANGLEInstancedArrays.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/ANGLEInstancedArrays.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/CHROMIUMSubscribeUniform.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/webgl/CHROMIUMSubscribeUniform.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webgl/CHROMIUMSubscribeUniform.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/CHROMIUMValuebuffer.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/CHROMIUMValuebuffer.cpp View 1 chunk +9 lines, -3 lines 0 comments Download
M Source/modules/webgl/CHROMIUMValuebuffer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/EXTBlendMinMax.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/EXTBlendMinMax.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/EXTBlendMinMax.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/EXTFragDepth.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/EXTFragDepth.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/EXTFragDepth.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/EXTShaderTextureLOD.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/EXTShaderTextureLOD.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/EXTShaderTextureLOD.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/EXTTextureFilterAnisotropic.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/EXTTextureFilterAnisotropic.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/EXTTextureFilterAnisotropic.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/EXTsRGB.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/EXTsRGB.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/EXTsRGB.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/OESElementIndexUint.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/OESElementIndexUint.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/OESElementIndexUint.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/OESStandardDerivatives.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/OESStandardDerivatives.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/OESStandardDerivatives.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/OESTextureFloat.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/OESTextureFloat.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/OESTextureFloat.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/OESTextureFloatLinear.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/OESTextureFloatLinear.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/OESTextureFloatLinear.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/OESTextureHalfFloat.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/OESTextureHalfFloat.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/OESTextureHalfFloat.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/OESTextureHalfFloatLinear.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/OESTextureHalfFloatLinear.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/OESTextureHalfFloatLinear.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/OESVertexArrayObject.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/webgl/OESVertexArrayObject.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/webgl/OESVertexArrayObject.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGL2RenderingContext.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/modules/webgl/WebGL2RenderingContextBase.h View 6 chunks +20 lines, -19 lines 0 comments Download
M Source/modules/webgl/WebGL2RenderingContextBase.cpp View 13 chunks +35 lines, -35 lines 0 comments Download
M Source/modules/webgl/WebGLActiveInfo.h View 1 chunk +6 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLActiveInfo.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLBuffer.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLBuffer.cpp View 2 chunks +11 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLBuffer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLCompressedTextureATC.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLCompressedTextureATC.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLCompressedTextureATC.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLCompressedTextureETC1.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLCompressedTextureETC1.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLCompressedTextureETC1.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLCompressedTexturePVRTC.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLCompressedTexturePVRTC.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLCompressedTexturePVRTC.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLCompressedTextureS3TC.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLCompressedTextureS3TC.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLCompressedTextureS3TC.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLContextGroup.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLContextObject.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLDebugRendererInfo.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLDebugRendererInfo.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLDebugRendererInfo.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLDebugShaders.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLDebugShaders.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLDebugShaders.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLDepthTexture.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLDepthTexture.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLDepthTexture.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLDrawBuffers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLDrawBuffers.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLDrawBuffers.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLExtension.h View 1 chunk +10 lines, -6 lines 0 comments Download
M Source/modules/webgl/WebGLExtension.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/webgl/WebGLFenceSync.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLFenceSync.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLFramebuffer.h View 4 chunks +5 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLFramebuffer.cpp View 8 chunks +31 lines, -21 lines 0 comments Download
M Source/modules/webgl/WebGLFramebuffer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLLoseContext.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLLoseContext.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/modules/webgl/WebGLLoseContext.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLObject.cpp View 1 chunk +11 lines, -4 lines 0 comments Download
M Source/modules/webgl/WebGLProgram.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLProgram.cpp View 3 chunks +14 lines, -7 lines 0 comments Download
M Source/modules/webgl/WebGLProgram.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLQuery.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLQuery.cpp View 1 chunk +9 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLQuery.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLRenderbuffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webgl/WebGLRenderbuffer.cpp View 1 chunk +11 lines, -4 lines 0 comments Download
M Source/modules/webgl/WebGLRenderbuffer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLRenderingContext.h View 1 chunk +23 lines, -23 lines 0 comments Download
M Source/modules/webgl/WebGLRenderingContextBase.h View 13 chunks +66 lines, -50 lines 0 comments Download
M Source/modules/webgl/WebGLRenderingContextBase.cpp View 28 chunks +71 lines, -71 lines 0 comments Download
M Source/modules/webgl/WebGLSampler.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLSampler.cpp View 1 chunk +9 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLSampler.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLShader.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLShader.cpp View 2 chunks +9 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLShader.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLShaderPrecisionFormat.h View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLShaderPrecisionFormat.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLShaderPrecisionFormat.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLSync.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLSync.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLTexture.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLTexture.cpp View 2 chunks +10 lines, -4 lines 0 comments Download
M Source/modules/webgl/WebGLTexture.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLTransformFeedback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLTransformFeedback.cpp View 1 chunk +9 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLTransformFeedback.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLUniformLocation.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLUniformLocation.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webgl/WebGLUniformLocation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLVertexArrayObject.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLVertexArrayObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLVertexArrayObject.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLVertexArrayObjectBase.h View 5 chunks +11 lines, -8 lines 0 comments Download
M Source/modules/webgl/WebGLVertexArrayObjectBase.cpp View 6 chunks +26 lines, -13 lines 0 comments Download
M Source/modules/webgl/WebGLVertexArrayObjectOES.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webgl/WebGLVertexArrayObjectOES.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webgl/WebGLVertexArrayObjectOES.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
Created Revert of [Oilpan] Migrate classes under module/webgl onto oilpan heap
5 years, 4 months ago (2015-08-11 15:43:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281953003/1
5 years, 4 months ago (2015-08-11 15:43:48 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-11 15:45:17 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 15:45:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200321

Powered by Google App Engine
This is Rietveld 408576698