Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: Source/modules/webgl/CHROMIUMValuebuffer.cpp

Issue 1281953003: Revert of [Oilpan] Migrate classes under module/webgl onto oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 6
7 #include "modules/webgl/CHROMIUMValuebuffer.h" 7 #include "modules/webgl/CHROMIUMValuebuffer.h"
8 8
9 #include "modules/webgl/WebGLRenderingContextBase.h" 9 #include "modules/webgl/WebGLRenderingContextBase.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 CHROMIUMValuebuffer* CHROMIUMValuebuffer::create(WebGLRenderingContextBase* ctx) 13 PassRefPtrWillBeRawPtr<CHROMIUMValuebuffer> CHROMIUMValuebuffer::create(WebGLRen deringContextBase* ctx)
14 { 14 {
15 return new CHROMIUMValuebuffer(ctx); 15 return adoptRefWillBeNoop(new CHROMIUMValuebuffer(ctx));
16 } 16 }
17 17
18 CHROMIUMValuebuffer::~CHROMIUMValuebuffer() 18 CHROMIUMValuebuffer::~CHROMIUMValuebuffer()
19 { 19 {
20 // See the comment in WebGLObject::detachAndDeleteObject(). 20 // Always call detach here to ensure that platform object deletion
21 // happens with Oilpan enabled. It keeps the code regular to do it
22 // with or without Oilpan enabled.
23 //
24 // See comment in WebGLBuffer's destructor for additional
25 // information on why this is done for WebGLSharedObject-derived
26 // objects.
21 detachAndDeleteObject(); 27 detachAndDeleteObject();
22 } 28 }
23 29
24 CHROMIUMValuebuffer::CHROMIUMValuebuffer(WebGLRenderingContextBase* ctx) 30 CHROMIUMValuebuffer::CHROMIUMValuebuffer(WebGLRenderingContextBase* ctx)
25 : WebGLSharedPlatform3DObject(ctx) 31 : WebGLSharedPlatform3DObject(ctx)
26 , m_hasEverBeenBound(false) 32 , m_hasEverBeenBound(false)
27 { 33 {
28 setObject(ctx->webContext()->createValuebufferCHROMIUM()); 34 setObject(ctx->webContext()->createValuebufferCHROMIUM());
29 } 35 }
30 36
31 void CHROMIUMValuebuffer::deleteObjectImpl(WebGraphicsContext3D* context3d) 37 void CHROMIUMValuebuffer::deleteObjectImpl(WebGraphicsContext3D* context3d)
32 { 38 {
33 context3d->deleteValuebufferCHROMIUM(m_object); 39 context3d->deleteValuebufferCHROMIUM(m_object);
34 m_object = 0; 40 m_object = 0;
35 } 41 }
36 42
37 } // namespace blink 43 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/webgl/CHROMIUMValuebuffer.h ('k') | Source/modules/webgl/CHROMIUMValuebuffer.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698