customtabs: Move the build files for the sample application to Chromium.

customtabs: Move the build files for the sample application to Chromium.

Committed: https://crrev.com/73fc2108fa6264a6133c1ccb0cb06ce1a64c70cb
Cr-Commit-Position: refs/heads/master@{#343129}

[Benoit L, 2015-08-05 14:07:23]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[Benoit L, 2015-08-05 14:07:23]

This CL is not final, but it is a first step to get the sample application
updated in Chromium.

Full plan:
- Remove the Chromium build files from the github repo
- Add the annotations target to android_tools
- This CL
- DEPS roll for the sample app

[Yusuf, 2015-08-10 05:45:08]

lgtm

[Yusuf, 2015-08-10 05:45:46]

lets carry this plan out soonish so that this build error doesnt block us from
rolling the new library changes.

[Yusuf, 2015-08-12 20:34:59]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-12 20:35:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1270403003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1270403003/1

[commit-bot: I haz the power, 2015-08-12 20:40:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 20:40:55]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[Yusuf, 2015-08-12 22:36:35]

We have rolled the necessary android_tools changes to chromium. Rerunning
through CQ.

[Yusuf, 2015-08-12 22:36:39]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-08-12 22:37:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1270403003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1270403003/1

[commit-bot: I haz the power, 2015-08-12 22:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 22:47:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yusuf, 2015-08-12 22:50:27]

yusufo@chromium.org changed reviewers:
+ cjhopman@chromium.org

[Yusuf, 2015-08-12 22:50:27]

adding cjhopman for all.gyp changes

Chris, we will be moving this file to chromium from the third_party repo and
handle all chromium build related changes within chromium and all gradle related
changes within the repo. Right now doing both in the repo is complicating
things.

[cjhopman, 2015-08-12 22:52:32]

lgtm

https://codereview.chromium.org/1270403003/diff/1/third_party/custom_tabs_cli...
File third_party/custom_tabs_client/custom_tabs_client.gyp (right):

https://codereview.chromium.org/1270403003/diff/1/third_party/custom_tabs_cli...
third_party/custom_tabs_client/custom_tabs_client.gyp:42: #
'aidl_interface_file': '<(java_in_dir)/common.aidl.txt',
Is this comment useful?

[Yusuf, 2015-08-12 22:54:05]

https://codereview.chromium.org/1270403003/diff/1/third_party/custom_tabs_cli...
File third_party/custom_tabs_client/custom_tabs_client.gyp (right):

https://codereview.chromium.org/1270403003/diff/1/third_party/custom_tabs_cli...
third_party/custom_tabs_client/custom_tabs_client.gyp:42: #
'aidl_interface_file': '<(java_in_dir)/common.aidl.txt',
On 2015/08/12 22:52:32, cjhopman wrote:
> Is this comment useful?

No... Do you mind if I update that with a follow up CL of my own?

[Yusuf, 2015-08-12 22:55:31]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-08-12 22:55:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1270403003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1270403003/1

[commit-bot: I haz the power, 2015-08-12 23:55:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-12 23:55:35]

Patchset 1 (id:??) landed as
https://crrev.com/73fc2108fa6264a6133c1ccb0cb06ce1a64c70cb
Cr-Commit-Position: refs/heads/master@{#343129}