Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1293313004: Fix build files and roll custom_tabs_client (Closed)

Created:
5 years, 4 months ago by Yusuf
Modified:
5 years, 4 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build files and roll custom_tabs_client A new folder has been added and shared classes moved there. Adding a new target to build those as well. BUG=522099 Committed: https://crrev.com/4ac5f41e200b00f8c5c96a28ad409013f80ea7d1 Cr-Commit-Position: refs/heads/master@{#344343}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix line overflow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/custom_tabs_client/README.chromium View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/custom_tabs_client/custom_tabs_client.gyp View 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Yusuf
5 years, 4 months ago (2015-08-19 18:43:09 UTC) #2
Ian Wen
lgtm https://codereview.chromium.org/1293313004/diff/1/third_party/custom_tabs_client/README.chromium File third_party/custom_tabs_client/README.chromium (right): https://codereview.chromium.org/1293313004/diff/1/third_party/custom_tabs_client/README.chromium#newcode14 third_party/custom_tabs_client/README.chromium:14: in different modes. Possible line overflow? Maybe it's ...
5 years, 4 months ago (2015-08-19 20:30:51 UTC) #3
Yusuf
https://codereview.chromium.org/1293313004/diff/1/third_party/custom_tabs_client/README.chromium File third_party/custom_tabs_client/README.chromium (right): https://codereview.chromium.org/1293313004/diff/1/third_party/custom_tabs_client/README.chromium#newcode14 third_party/custom_tabs_client/README.chromium:14: in different modes. On 2015/08/19 20:30:51, Ian Wen wrote: ...
5 years, 4 months ago (2015-08-19 20:43:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293313004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293313004/20001
5 years, 4 months ago (2015-08-19 20:44:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-19 22:03:27 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 22:04:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ac5f41e200b00f8c5c96a28ad409013f80ea7d1
Cr-Commit-Position: refs/heads/master@{#344343}

Powered by Google App Engine
This is Rietveld 408576698