Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1308563006: Fix window.open crashes on custom tabs (Closed)

Created:
5 years, 4 months ago by Yusuf
Modified:
5 years, 4 months ago
Reviewers:
gone, Maria
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix window.open crashes on custom tabs Overrides the tabwebcontentdelegate calls that assumes the presence of a tabcreator which is not there for custom tabs. Loads the targetUrl on the same page instead. BUG=524562 Committed: https://crrev.com/7534de1539af204312dbfafa8fa8ab966a1e1989 Cr-Commit-Position: refs/heads/master@{#345525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java View 2 chunks +31 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Yusuf
5 years, 4 months ago (2015-08-26 00:32:08 UTC) #2
Maria
lgtm
5 years, 4 months ago (2015-08-26 00:49:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308563006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308563006/1
5 years, 4 months ago (2015-08-26 00:54:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-26 01:39:11 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 01:39:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7534de1539af204312dbfafa8fa8ab966a1e1989
Cr-Commit-Position: refs/heads/master@{#345525}

Powered by Google App Engine
This is Rietveld 408576698