Add signals to make callback more reliable

Add signals to make callback more reliable

Adds notifying the client on
pageLoadFailed: on security error and actual load fail
pageLoadAborted: on user starting new navigation while one is unfinished
tabVisible and  tabHidden.

BUG=517894
Committed: https://crrev.com/c1873995ca73a5bb03f49fec459572eda534539c
Cr-Commit-Position: refs/heads/master@{#343232}

[Yusuf, 2015-08-13 05:55:12]

yusufo@chromium.org changed reviewers:
+ lizeb@chromium.org

[Benoit L, 2015-08-13 08:18:18]

lgtm, thank you.

https://codereview.chromium.org/1292493002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/1292493002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:229:
if (getActivityTab() != null) getActivityTab().hide();
Should we do something in onPause() rather?

[Yusuf, 2015-08-13 17:28:18]

https://codereview.chromium.org/1292493002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/1292493002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:229:
if (getActivityTab() != null) getActivityTab().hide();
On 2015/08/13 08:18:18, Benoit L wrote:
> Should we do something in onPause() rather?

OK, moved the signal to onPause. Also after talking with dtrainor, switched to
explicitly calling notify from the activity to avoid any side effects.

[Yusuf, 2015-08-13 17:29:08]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-08-13 17:29:08]

The patchset sent to the CQ was uploaded after l-g-t-m from lizeb@chromium.org
Link to the patchset: https://codereview.chromium.org/1292493002/#ps20001
(title: "Signal hidden onPause rather than onStop")

[commit-bot: I haz the power, 2015-08-13 17:29:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1292493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1292493002/20001

[commit-bot: I haz the power, 2015-08-13 18:07:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-13 18:09:46]

Patchset 2 (id:??) landed as
https://crrev.com/c1873995ca73a5bb03f49fec459572eda534539c
Cr-Commit-Position: refs/heads/master@{#343232}