Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303613002: Start using the third_party/android_tools target for customtabs library (Closed)

Created:
5 years, 4 months ago by Yusuf
Modified:
5 years, 4 months ago
Reviewers:
pasko, Benoit L, newt (away)
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start using the third_party/android_tools target for customtabs library This removes the temporary code for customtabs and starts using the target built out of the jar file. It needs a corresponding android_tools change to land. It also moves a few constants that are not currently inside the support library to individual files BUG=522099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -287 lines) Patch
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 3 chunks +1 line, -11 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/android/java/src/android/support/customtabs/CustomTabsCallback.java View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/android/java/src/android/support/customtabs/CustomTabsIntent.java View 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/android/java/src/android/support/customtabs/ICustomTabsCallback.aidl View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/android/java/src/android/support/customtabs/ICustomTabsService.aidl View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/android/java/src/android/support/customtabs/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/android/java/src/android/support/customtabs/common.aidl View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java View 4 chunks +8 lines, -24 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1270403003 Patch 1

Messages

Total messages: 3 (1 generated)
Yusuf
newt@ for build system changes pasko@ and lizeb@ for customtabs related changes
5 years, 4 months ago (2015-08-18 23:48:34 UTC) #2
Yusuf
5 years, 4 months ago (2015-08-19 00:01:13 UTC) #3 
Please ignore patch #1, I will be uploading a new one soon with a different
plan.

Powered by Google App Engine
This is Rietveld 408576698