Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1318003005: Switch to using url bar hiding by default in customtabs (Closed)

Created:
5 years, 3 months ago by Yusuf
Modified:
5 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to using url bar hiding by default in customtabs The extra and customization for this had been added on m45 but the initial default was not hiding the url bar. This switches the default. Clients can still opt to not hide the url bar on user scroll. BUG=527913 Committed: https://crrev.com/43b3af2a120269731f0d7edf44121281b08e3e5a Cr-Commit-Position: refs/heads/master@{#347509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Yusuf
5 years, 3 months ago (2015-09-04 17:35:55 UTC) #2
Ted C
lgtm
5 years, 3 months ago (2015-09-04 17:37:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318003005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318003005/1
5 years, 3 months ago (2015-09-04 17:50:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/65361)
5 years, 3 months ago (2015-09-04 18:11:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318003005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318003005/1
5 years, 3 months ago (2015-09-04 21:10:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 22:41:52 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 22:42:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43b3af2a120269731f0d7edf44121281b08e3e5a
Cr-Commit-Position: refs/heads/master@{#347509}

Powered by Google App Engine
This is Rietveld 408576698