Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 1305063010: Disable PrecacheLauncher and ExternalPrerenderHandler tests on svelte (Closed)

Created:
5 years, 3 months ago by Yusuf
Modified:
5 years, 3 months ago
Reviewers:
Ted C, twifkak
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, wifiprefetch-reviews_google.com, davidben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable PrecacheLauncher and ExternalPrerenderHandler tests on svelte These tests depend on prerender feature which is disabled on svelte devices. BUG=529490 Committed: https://crrev.com/5c92b7e76b8c09fc7f79d0ddc01ceda4a3e3a3c4 Cr-Commit-Position: refs/heads/master@{#347853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java View 5 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java View 4 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
Yusuf
5 years, 3 months ago (2015-09-08 23:57:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305063010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305063010/1
5 years, 3 months ago (2015-09-08 23:57:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305063010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305063010/20001
5 years, 3 months ago (2015-09-09 00:07:58 UTC) #6
Ted C
lgtm
5 years, 3 months ago (2015-09-09 00:09:26 UTC) #8
twifkak
lgtm
5 years, 3 months ago (2015-09-09 00:29:25 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-09 00:39:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305063010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305063010/1
5 years, 3 months ago (2015-09-09 00:55:29 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 01:02:35 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 01:03:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c92b7e76b8c09fc7f79d0ddc01ceda4a3e3a3c4
Cr-Commit-Position: refs/heads/master@{#347853}

Powered by Google App Engine
This is Rietveld 408576698