Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1338903002: Update the key for getting animRes out of an Activity bundle (Closed)

Created:
5 years, 3 months ago by Yusuf
Modified:
5 years, 3 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the key for getting animRes out of an Activity bundle In M, the key used for these fields inside the ActivityOptions have changed which makes the exit animation not work on M devices. This adds the new keys for M. BUG=530770 Committed: https://crrev.com/1427d86d2cc38742323c1950747404fb314fb04b Cr-Commit-Position: refs/heads/master@{#348728}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update the version code to M #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java View 1 2 chunks +8 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
Yusuf
5 years, 3 months ago (2015-09-11 22:43:56 UTC) #2
Ian Wen
lgtm with a nit. https://codereview.chromium.org/1338903002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java (right): https://codereview.chromium.org/1338903002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java#newcode79 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:79: Build.VERSION.SDK_INT > Build.VERSION_CODES.LOLLIPOP_MR1 Can we ...
5 years, 3 months ago (2015-09-11 23:10:29 UTC) #3
Yusuf
https://codereview.chromium.org/1338903002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java (right): https://codereview.chromium.org/1338903002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java#newcode79 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:79: Build.VERSION.SDK_INT > Build.VERSION_CODES.LOLLIPOP_MR1 On 2015/09/11 23:10:29, Ian Wen wrote: ...
5 years, 3 months ago (2015-09-12 03:04:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338903002/20001
5 years, 3 months ago (2015-09-14 20:46:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 21:48:22 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1427d86d2cc38742323c1950747404fb314fb04b Cr-Commit-Position: refs/heads/master@{#348728}
5 years, 3 months ago (2015-09-14 21:48:56 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:37:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1427d86d2cc38742323c1950747404fb314fb04b
Cr-Commit-Position: refs/heads/master@{#348728}

Powered by Google App Engine
This is Rietveld 408576698