Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 1268483004: Plumb the anonymize rect color to toolbar_layer from Tab#getThemeColor (Closed)

Created:
5 years, 4 months ago by Yusuf
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@tabHasThemeColor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb the anonymize rect color to toolbar_layer from Tab#getThemeColor Makes LayoutTab aware of the textbox background color so that it can be used for anonymizeRect background. Changes the boolean used to set the color for anonymizeRect to be an int and signal the actual color. Adds tinting to toolbarPhone animation drawables so that fullscreen works properly. No visual changes. Yet. BUG=507340 Committed: https://crrev.com/fb46d0a352393374bf80feb5ef67fb3572481f53 Cr-Commit-Position: refs/heads/master@{#345714}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebased #

Patch Set 3 : null check drawable before setting tint #

Patch Set 4 : Moved all flow control to Tab #

Total comments: 4

Patch Set 5 : Removed unnecessary boolean #

Patch Set 6 : Rebased #

Patch Set 7 : Renamed BrandColorUtils in implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -26 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java View 1 2 3 4 5 6 3 chunks +8 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java View 3 chunks +11 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherDrawable.java View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 2 3 4 5 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java View 1 2 3 4 5 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/android/compositor/compositor_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/toolbar_layer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/toolbar_layer.cc View 1 2 3 4 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (11 generated)
Yusuf
5 years, 4 months ago (2015-08-03 20:06:35 UTC) #2
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/1268483004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java File chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java (right): https://codereview.chromium.org/1268483004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java#newcode56 chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java:56: private static int getColorWithOverlay(int baseColor, int overlayColor, float ...
5 years, 4 months ago (2015-08-03 20:12:44 UTC) #3
Yusuf
https://codereview.chromium.org/1268483004/diff/1/chrome/browser/android/compositor/layer/toolbar_layer.cc File chrome/browser/android/compositor/layer/toolbar_layer.cc (right): https://codereview.chromium.org/1268483004/diff/1/chrome/browser/android/compositor/layer/toolbar_layer.cc#newcode14 chrome/browser/android/compositor/layer/toolbar_layer.cc:14: const SkColor kNormalAnonymizeContentColor = SK_ColorWHITE; On 2015/08/03 20:12:44, David ...
5 years, 4 months ago (2015-08-03 20:39:08 UTC) #4
Yusuf
Rebased this and fixed a NPE. Also moved all theme color related controls to Tab ...
5 years, 4 months ago (2015-08-25 20:55:25 UTC) #5
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/1268483004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java File chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java (right): https://codereview.chromium.org/1268483004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java#newcode51 chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java:51: boolean shouldUseOpaqueTextboxBackground = shouldUseOpaqueTextboxBackground(color); do we need this ...
5 years, 4 months ago (2015-08-26 00:16:40 UTC) #6
Yusuf
https://codereview.chromium.org/1268483004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java File chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java (right): https://codereview.chromium.org/1268483004/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java#newcode51 chrome/android/java/src/org/chromium/chrome/browser/document/BrandColorUtils.java:51: boolean shouldUseOpaqueTextboxBackground = shouldUseOpaqueTextboxBackground(color); On 2015/08/26 00:16:40, David Trainor ...
5 years, 3 months ago (2015-08-26 20:06:49 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268483004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268483004/80001
5 years, 3 months ago (2015-08-26 20:08:10 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-26 21:04:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268483004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268483004/80001
5 years, 3 months ago (2015-08-26 21:11:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/93258)
5 years, 3 months ago (2015-08-26 21:19:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268483004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268483004/100001
5 years, 3 months ago (2015-08-26 21:53:04 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/112270) linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-08-26 22:13:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268483004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268483004/120001
5 years, 3 months ago (2015-08-26 22:19:57 UTC) #24
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 3 months ago (2015-08-26 23:10:54 UTC) #25
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 23:11:36 UTC) #26
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/fb46d0a352393374bf80feb5ef67fb3572481f53
Cr-Commit-Position: refs/heads/master@{#345714}

Powered by Google App Engine
This is Rietveld 408576698