Another attempt to unflake CustomTabExternalNavigationTest

Another attempt to unflake CustomTabExternalNavigationTest

Try using one of the data urls in case the flakiness is happening
because about://blank happens too fast
Also getWebContents#isReady()
is never true even if about://blank has loaded so use progress
instead

BUG=519613
Committed: https://crrev.com/364f6e69f92e17e46e0c93ac6d3f5ee4d038ffe6
Cr-Commit-Position: refs/heads/master@{#344045}

[Yusuf, 2015-08-18 18:28:36]

yusufo@chromium.org changed reviewers:
+ ianwen@chromium.org

[Ian Wen, 2015-08-18 18:42:15]

Could we use Tab#isLoading() to help us?

https://codereview.chromium.org/1300903002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
(right):

https://codereview.chromium.org/1300903002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:70:
if (tab.getProgress() != 0) pageLoadFinishedHelper.waitForCallback(0);
If the progress is 0, then we don't wait for the the callback?

Then what if the progress is 100, and the page load is already complete. Should
we wait?

https://codereview.chromium.org/1300903002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java
(right):

https://codereview.chromium.org/1300903002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java:95:
@FlakyTest
These tests are still flaky after the change?

[Yusuf, 2015-08-18 19:00:34]

https://codereview.chromium.org/1300903002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
(right):

https://codereview.chromium.org/1300903002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:70:
if (tab.getProgress() != 0) pageLoadFinishedHelper.waitForCallback(0);
On 2015/08/18 18:42:14, Ian Wen wrote:
> If the progress is 0, then we don't wait for the the callback?
> 
> Then what if the progress is 100, and the page load is already complete.
Should
> we wait?

Done. Using isLoading now.

https://codereview.chromium.org/1300903002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java
(right):

https://codereview.chromium.org/1300903002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java:95:
@FlakyTest
On 2015/08/18 18:42:14, Ian Wen wrote:
> These tests are still flaky after the change?

No. But now that this has been marked flaky I would say we should wait and have
this run a few times to be monitored on the flakiness dashboard. Then I can
remove the flaky annotations tomorrow after it keeps passing.

[Ian Wen, 2015-08-18 20:52:39]

lgtm. Thanks!

[Yusuf, 2015-08-18 20:53:28]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:54:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300903002/20001

[Ian Wen, 2015-08-18 20:59:23]

Yusuf, you might need a TBR=pasko@chromium.org in commit msg. I am not the owner
of the folder yet. (Will add myself momentarily.)

[Yusuf, 2015-08-18 21:00:29]

On 2015/08/18 20:59:23, Ian Wen wrote:
> Yusuf, you might need a mailto:TBR=pasko@chromium.org in commit msg. I am not
the owner
> of the folder yet. (Will add myself momentarily.)

I am an owner, so as long as you are a committer it should be fine I think.

[commit-bot: I haz the power, 2015-08-18 22:03:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-18 22:04:28]

Patchset 2 (id:??) landed as
https://crrev.com/364f6e69f92e17e46e0c93ac6d3f5ee4d038ffe6
Cr-Commit-Position: refs/heads/master@{#344045}