Add a rappor metric for getting package names for custom tabs clients

Add a rappor metric for getting package names for custom tabs clients

This adds a static call to the rappor service bridge for collecting
a string metric and uses it to record the package names for custom tabs
client anonymously.

BUG=530653
Committed: https://crrev.com/4828ce54ef48864efaf870516312d131fc861999
Cr-Commit-Position: refs/heads/master@{#351832}

[Yusuf, 2015-09-16 22:17:58]

yusufo@chromium.org changed reviewers:
+ asvitkine@chromium.org, newt@chromium.org

[Yusuf, 2015-09-16 22:17:59]

asvitkine for rappor related changes. Please let me know if there is any other
places I should be updating about this. Do we need a set of possible values
right now?

newt@ for android bits.

[newt (away), 2015-09-17 02:21:46]

I'm not at all familiar with rappor. Maybe someone else would be better to
review this?

[Alexei Svitkine (slow), 2015-09-17 14:54:00]

asvitkine@chromium.org changed reviewers:
+ holte@chromium.org
- asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-09-17 14:54:00]

I'm pretty overloaded this week, so over to +holte@ to help with the RAPPOR
review. Thanks!

[Steven Holte, 2015-09-18 00:21:57]

This looks fine code wise.  What does the space of package names look like?  Do
you have a candidate set you think will be comprehensive?  Not sure if you
discussed this with any of the Rappor folks yet.

[Yusuf, 2015-09-18 16:32:28]

On 2015/09/18 00:21:57, Steven Holte wrote:
> This looks fine code wise.  What does the space of package names look like? 
Do
> you have a candidate set you think will be comprehensive?  Not sure if you
> discussed this with any of the Rappor folks yet.

I haven't. This was my first step in initiating a conversation :).

We might have a candidate set but I am not sure how big comprehensive is here?
Or how inclusive it should be. Does the sample set has to include all possible
values? Or all possible values we care about? And is there a lower bound on
how big it can be? Should I have been asking these questions to Rappor folks
before
sending the review? :)

[Steven Holte, 2015-09-18 19:29:39]

On 2015/09/18 16:32:28, Yusuf wrote:
> On 2015/09/18 00:21:57, Steven Holte wrote:
> > This looks fine code wise.  What does the space of package names look like? 
> Do
> > you have a candidate set you think will be comprehensive?  Not sure if you
> > discussed this with any of the Rappor folks yet.
> 
> I haven't. This was my first step in initiating a conversation :).
> 
> We might have a candidate set but I am not sure how big comprehensive is here?
> Or how inclusive it should be. Does the sample set has to include all possible
> values? Or all possible values we care about? And is there a lower bound on
> how big it can be? Should I have been asking these questions to Rappor folks
> before
> sending the review? :)

There are some setup steps on the analysis side for adding new candidate sets,
so it's a good idea to loop rappor-team@ in.    "Comprehensive" should include
all of the values you care about, and any values you expect might be common. 
The smaller the % of reports that come from values that you don't have a
candidate for, the better.

[Steven Holte, 2015-09-18 19:37:53]

lgtm for code review.  We can set up the candidate set in parallel.

[Yusuf, 2015-09-18 20:25:46]

yusufo@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Yusuf, 2015-09-18 20:25:46]

@mariakhomenko for android changes

[Maria, 2015-09-18 20:31:23]

lgtm

[Yusuf, 2015-09-22 23:29:04]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-22 23:30:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/1

[commit-bot: I haz the power, 2015-09-22 23:36:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 23:36:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yusuf, 2015-09-22 23:46:22]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-22 23:47:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/20001

[commit-bot: I haz the power, 2015-09-23 06:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 06:23:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Yusuf, 2015-09-29 18:14:55]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-29 18:16:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/40001

[commit-bot: I haz the power, 2015-09-29 18:23:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 18:23:57]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Yusuf, 2015-09-29 19:06:01]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-29 19:07:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/60001

[commit-bot: I haz the power, 2015-09-29 19:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 19:34:56]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Yusuf, 2015-09-29 23:07:36]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-09-29 23:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org,
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/1352693002/#ps60001
(title: "rebased agai")

[commit-bot: I haz the power, 2015-09-29 23:09:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/60001

[commit-bot: I haz the power, 2015-09-29 23:21:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 23:21:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yusuf, 2015-09-29 23:23:27]

yusufo@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Yusuf, 2015-09-29 23:23:27]

dfalcantara for OWNERS on chrome/browser/android/OWNERS

[gone, 2015-09-29 23:51:47]

lgtm

[Yusuf, 2015-09-30 16:55:34]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-09-30 16:55:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/60001

[commit-bot: I haz the power, 2015-09-30 19:56:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 19:56:49]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Yusuf, 2015-09-30 21:20:15]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-09-30 21:20:16]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org,
dfalcantara@chromium.org, mariakhomenko@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1352693002/#ps80001
(title: "Exclude Chrome package name from recorded packages")

[commit-bot: I haz the power, 2015-09-30 21:22:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/80001

[commit-bot: I haz the power, 2015-09-30 21:27:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 21:27:55]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Yusuf, 2015-09-30 23:16:36]

yusufo@chromium.org changed reviewers:
+ lizeb@chromium.org
- newt@chromium.org

[Yusuf, 2015-09-30 23:16:36]

Moved the recording logic to the activity since this will make sure it is called
when native library is there and also recorded only once after the tab is
created.

lizeb@ do you mind taking a final look and see whether this makes sense?

[Yusuf, 2015-09-30 23:16:42]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-30 23:17:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/100001

[commit-bot: I haz the power, 2015-09-30 23:31:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 23:31:05]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[Yusuf, 2015-09-30 23:46:08]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-30 23:46:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/120001

[commit-bot: I haz the power, 2015-10-01 00:30:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 00:30:06]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Benoit L, 2015-10-01 11:31:45]

On 2015/10/01 00:30:06, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

lgtm

[Yusuf, 2015-10-01 16:16:09]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-10-01 16:16:09]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org,
dfalcantara@chromium.org, mariakhomenko@chromium.org, lizeb@chromium.org
Link to the patchset: https://codereview.chromium.org/1352693002/#ps140001
(title: "Rebased")

[commit-bot: I haz the power, 2015-10-01 16:31:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1352693002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1352693002/140001

[commit-bot: I haz the power, 2015-10-01 17:29:31]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-10-01 17:30:29]

Patchset 8 (id:??) landed as
https://crrev.com/4828ce54ef48864efaf870516312d131fc861999
Cr-Commit-Position: refs/heads/master@{#351832}