Part 1 of cc/ directory shuffles: base

Part 1 of cc/ directory shuffles: base

This establishes cc/base/ as discussed in https://groups.google.com/a/chromium.org/d/msg/graphics-dev/wNRsl3BwU_Y/jFXeRQq7e30J.

This patch will likely touch the most locations since it moves cc/switches.h

BUG=190824
TBR=piman@chromium.org, thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188681

[jamesr, 2013-03-13 23:01:36]

It begins!

Patch generated by doing the following:

1.) Downloading
https://docs.google.com/a/chromium.org/spreadsheet/ccc?key=0Ah3FsySZx1hSdDdZM...
as a text file
2.) Cleaning up the text file a bit
3.) Running this command:
for x in `egrep "base$" moves.txt | awk '{print $1}'`; do
./tools/git/move_source_file.py cc/$x cc/base/$x; done
4.) Reverting bad changes that script made to apps/apps.gypi and
courgette/courgette.gypi (it assumed other switches.h were the same as
cc/switches.h)
5.) Running tools/sort-headers.py on cc/base/*.h to fix the include order

[enne (OOO), 2013-03-13 23:27:37]

lgtm, with one quibble about what goes where.

https://codereview.chromium.org/12472028/diff/1/cc/cc.gyp
File cc/cc.gyp (right):

https://codereview.chromium.org/12472028/diff/1/cc/cc.gyp#newcode219
cc/cc.gyp:219: 'ring_buffer.h',
Does this belong in base? Other independent data structures like tiling data go
there.

[jamesr, 2013-03-13 23:38:46]

On 2013/03/13 23:27:37, enne wrote:
> lgtm, with one quibble about what goes where.
> 
> https://codereview.chromium.org/12472028/diff/1/cc/cc.gyp
> File cc/cc.gyp (right):
> 
> https://codereview.chromium.org/12472028/diff/1/cc/cc.gyp#newcode219
> cc/cc.gyp:219: 'ring_buffer.h',
> Does this belong in base? Other independent data structures like tiling data
go
> there.

I'm planning to put it in cc/debug/ since it's only used there.  I'm not sure if
it's performance tuned, etc, enough to use more generally.  We can move it when
we need to.

[jamesr, 2013-03-18 06:11:47]

tbr piman@ for content/, ui/compositor/
tbr thakis@ for chrome/

[jamesr, 2013-03-18 06:14:01]

Committed patchset #1 manually as r188681 (presubmit successful).

[Nico, 2013-03-18 16:18:00]

The three chrome/ files lgtm.

However, it's pretty weird that there's cc/base/thread.h / worker_pool.h in
addition to base/threading/thread.h / worker_pool.h. They look relatively
different (cc's worker_pool.h looks a bit like base/task_runner.h), but you
should consider consolidating this more over time.

[piman, 2013-03-18 16:21:30]

lgtm