Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, shans, tzik, eric.carlson_apple.com, apavlov+blink_chromium.org, lushnikov+blink_chromium.org, Yoav Weiss, mvanouwerkerk+watch_chromium.org, yurys+blink_chromium.org, devtools-reviews_chromium.org, Eric Willigers, rjwright, philipj_slow, caseq+blink_chromium.org, timvolodine, feature-media-reviews_chromium.org, nhiroki, darktears, dcheng, gavinp+prerender_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, pfeldman+blink_chromium.org, groby+blinkspell_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/web/. - We should specify just one of them to a function. This was done by the following command. % sed -i "" -E "s/virtual (.*) final/\1 final/g; s/virtual (.*) override/\1 override/g; s/override final/final/g" <files> - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1155 lines, -1155 lines) Patch
M Source/web/AssociatedURLLoader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/ColorChooserPopupUIController.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/web/ColorChooserUIController.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/web/ContextFeaturesClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/ContextMenuClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/DatabaseClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/DateTimeChooserImpl.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/web/DragClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/EditorClientImpl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/web/ExternalDateTimeChooser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/ExternalDateTimeChooser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/ExternalPopupMenu.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/web/ExternalPopupMenuTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +98 lines, -98 lines 0 comments Download
M Source/web/GeolocationClientProxy.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/web/GraphicsLayerFactoryChromium.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/ImageDecodeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/IndexedDBClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/LinkHighlight.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/web/LocalFileSystemClient.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/MIDIClientProxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/MediaKeysClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/NavigatorContentUtilsClientImpl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/NotificationPermissionClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/NotificationPermissionClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/PluginPlaceholderImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/PluginPlaceholderImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupMenuImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupMenuImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/RemoteFrameClientImpl.h View 1 chunk +16 lines, -16 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +20 lines, -20 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +22 lines, -22 lines 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/SpeechRecognitionClientProxy.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/web/SpellCheckerClientImpl.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/web/StorageClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/StorageQuotaClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/SuspendableScriptExecutor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/UserMediaClientImpl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/web/ValidationMessageClientImpl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/WebDOMActivityLogger.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/WebDataSourceImpl.h View 2 chunks +15 lines, -15 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsFrontendImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFileChooserCompletionImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebFontImpl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/web/WebHelperPluginImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebKit.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebLeakDetector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 2 chunks +139 lines, -139 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.h View 3 chunks +36 lines, -36 lines 0 comments Download
M Source/web/WebPagePopupImpl.h View 1 chunk +23 lines, -23 lines 0 comments Download
M Source/web/WebPluginContainerImpl.h View 2 chunks +54 lines, -54 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 2 chunks +122 lines, -122 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 2 chunks +136 lines, -136 lines 0 comments Download
M Source/web/WebSocketChannelClientProxy.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/web/WebSocketImpl.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/web/WebTextCheckingCompletionImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.h View 6 chunks +143 lines, -143 lines 0 comments Download
M Source/web/WorkerGlobalScopeProxyProviderImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/tests/FakeWebPlugin.h View 1 chunk +19 lines, -19 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/PrerenderingTest.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 26 chunks +46 lines, -46 lines 0 comments Download
M Source/web/tests/WebHelperPluginTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/tests/WebPluginContainerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 10 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, please review this.
5 years, 5 months ago (2015-07-08 03:45:44 UTC) #2
keishi
lgtm
5 years, 5 months ago (2015-07-08 03:55:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230533002/1
5 years, 5 months ago (2015-07-08 04:10:56 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 04:16:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198456

Powered by Google App Engine
This is Rietveld 408576698