Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: Source/web/ExternalPopupMenuTest.cpp

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ExternalPopupMenu.h ('k') | Source/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ExternalPopupMenuTest.cpp
diff --git a/Source/web/ExternalPopupMenuTest.cpp b/Source/web/ExternalPopupMenuTest.cpp
index 0f1f23abe9d6830306b69f7426eef4ce35b6f110..b4350bdc7cd7425c4f134f1ee6cefdc92681ab6c 100644
--- a/Source/web/ExternalPopupMenuTest.cpp
+++ b/Source/web/ExternalPopupMenuTest.cpp
@@ -81,7 +81,7 @@ public:
ExternalPopupMenuDisplayNoneItemsTest() { }
protected:
- virtual void SetUp() override
+ void SetUp() override
{
m_popupMenuClient.setListSize(kListSize);
@@ -117,7 +117,7 @@ TEST_F(ExternalPopupMenuDisplayNoneItemsTest, IndexMappingTest)
class ExternalPopupMenuWebFrameClient : public FrameTestHelpers::TestWebFrameClient {
public:
- virtual WebExternalPopupMenu* createExternalPopupMenu(const WebPopupMenuInfo&, WebExternalPopupMenuClient*) override
+ WebExternalPopupMenu* createExternalPopupMenu(const WebPopupMenuInfo&, WebExternalPopupMenuClient*) override
{
return &m_mockWebExternalPopupMenu;
}
@@ -127,11 +127,11 @@ public:
}
private:
class MockWebExternalPopupMenu : public WebExternalPopupMenu {
- virtual void show(const WebRect& bounds) override
+ void show(const WebRect& bounds) override
{
m_shownBounds = bounds;
}
- virtual void close() override { }
+ void close() override { }
public:
WebRect shownBounds() const
« no previous file with comments | « Source/web/ExternalPopupMenu.h ('k') | Source/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698