Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: Source/web/tests/WebHelperPluginTest.cpp

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebHelperPluginTest.cpp
diff --git a/Source/web/tests/WebHelperPluginTest.cpp b/Source/web/tests/WebHelperPluginTest.cpp
index 6328bc8e90e500d3cef06801a4c49848a87e1ee6..c6ed4545ebb20b32a13508055330c4302c1d7ce3 100644
--- a/Source/web/tests/WebHelperPluginTest.cpp
+++ b/Source/web/tests/WebHelperPluginTest.cpp
@@ -22,17 +22,17 @@ public:
: FakeWebPlugin(frame, params)
{
}
- virtual ~FakePlaceholderWebPlugin() { }
+ ~FakePlaceholderWebPlugin() override {}
- virtual bool isPlaceholder() override { return true; }
+ bool isPlaceholder() override { return true; }
};
class WebHelperPluginFrameClient : public FrameTestHelpers::TestWebFrameClient {
public:
- WebHelperPluginFrameClient() : m_createPlaceholder(false) { }
- virtual ~WebHelperPluginFrameClient() { }
+ WebHelperPluginFrameClient() : m_createPlaceholder(false) {}
+ ~WebHelperPluginFrameClient() override {}
- virtual WebPlugin* createPlugin(WebLocalFrame* frame, const WebPluginParams& params) override
+ WebPlugin* createPlugin(WebLocalFrame* frame, const WebPluginParams& params) override
{
return m_createPlaceholder ? new FakePlaceholderWebPlugin(frame, params) : new FakeWebPlugin(frame, params);
}
@@ -45,7 +45,7 @@ private:
class WebHelperPluginTest : public ::testing::Test {
protected:
- virtual void SetUp() override
+ void SetUp() override
{
m_helper.initializeAndLoad("about:blank", false, &m_frameClient);
}
« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698