Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Unified Diff: Source/web/SuspendableScriptExecutor.h

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/StorageQuotaClientImpl.h ('k') | Source/web/UserMediaClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/SuspendableScriptExecutor.h
diff --git a/Source/web/SuspendableScriptExecutor.h b/Source/web/SuspendableScriptExecutor.h
index 0c6d40af4119490882e9dc1deba8117cf9e7d870..ecbee08bcdafa985302e67e78c99303c65ed3a8e 100644
--- a/Source/web/SuspendableScriptExecutor.h
+++ b/Source/web/SuspendableScriptExecutor.h
@@ -20,9 +20,9 @@ class SuspendableScriptExecutor final : public RefCountedWillBeRefCountedGarbage
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SuspendableScriptExecutor);
public:
static void createAndRun(LocalFrame*, int worldID, const WillBeHeapVector<ScriptSourceCode>& sources, int extensionGroup, bool userGesture, WebScriptExecutionCallback*);
- virtual ~SuspendableScriptExecutor();
+ ~SuspendableScriptExecutor() override;
- virtual void contextDestroyed() override;
+ void contextDestroyed() override;
// Eager finalization is needed to promptly stop this timer object.
// (see DOMTimer comment for more.)
@@ -32,7 +32,7 @@ public:
private:
SuspendableScriptExecutor(LocalFrame*, int worldID, const WillBeHeapVector<ScriptSourceCode>& sources, int extensionGroup, bool userGesture, WebScriptExecutionCallback*);
- virtual void fired() override;
+ void fired() override;
void run();
void executeAndDestroySelf();
« no previous file with comments | « Source/web/StorageQuotaClientImpl.h ('k') | Source/web/UserMediaClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698