Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2465)

Unified Diff: Source/web/ValidationMessageClientImpl.h

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/UserMediaClientImpl.h ('k') | Source/web/WebDOMActivityLogger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ValidationMessageClientImpl.h
diff --git a/Source/web/ValidationMessageClientImpl.h b/Source/web/ValidationMessageClientImpl.h
index 48cf416f30f0d7812099cb7fd4f50fd14546932e..7519f80a04020b5a1e40b0e1a6e5b728c5b16ab6 100644
--- a/Source/web/ValidationMessageClientImpl.h
+++ b/Source/web/ValidationMessageClientImpl.h
@@ -41,7 +41,7 @@ class ValidationMessageClientImpl final : public NoBaseWillBeGarbageCollectedFin
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ValidationMessageClientImpl);
public:
static PassOwnPtrWillBeRawPtr<ValidationMessageClientImpl> create(WebViewImpl&);
- virtual ~ValidationMessageClientImpl();
+ ~ValidationMessageClientImpl() override;
DECLARE_VIRTUAL_TRACE();
@@ -50,11 +50,11 @@ private:
void checkAnchorStatus(Timer<ValidationMessageClientImpl>*);
FrameView* currentView();
- virtual void showValidationMessage(const Element& anchor, const String& message, TextDirection messageDir, const String& subMessage, TextDirection subMessageDir) override;
- virtual void hideValidationMessage(const Element& anchor) override;
- virtual bool isValidationMessageVisible(const Element& anchor) override;
- virtual void documentDetached(const Document&) override;
- virtual void willBeDestroyed() override;
+ void showValidationMessage(const Element& anchor, const String& message, TextDirection messageDir, const String& subMessage, TextDirection subMessageDir) override;
+ void hideValidationMessage(const Element& anchor) override;
+ bool isValidationMessageVisible(const Element& anchor) override;
+ void documentDetached(const Document&) override;
+ void willBeDestroyed() override;
WebViewImpl& m_webView;
RawPtrWillBeMember<const Element> m_currentAnchor;
« no previous file with comments | « Source/web/UserMediaClientImpl.h ('k') | Source/web/WebDOMActivityLogger.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698