Source/web/PluginPlaceholderImpl.h - Issue 1230533002: Fix virtual/override/final usage in Source/web/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PluginPlaceholderImpl.h

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/PluginPlaceholderImpl.h

diff --git a/Source/web/PluginPlaceholderImpl.h b/Source/web/PluginPlaceholderImpl.h

index d31414e62b7de30aee3575a5d5f2838389f09b7f..f2b6b1551ed8495d868a71b6ef3b5395f1eddae1 100644

--- a/Source/web/PluginPlaceholderImpl.h

+++ b/Source/web/PluginPlaceholderImpl.h

@@ -33,13 +33,13 @@ public:

#if ENABLE(OILPAN)

~PluginPlaceholderImpl();

#else

- virtual ~PluginPlaceholderImpl() override;

+ ~PluginPlaceholderImpl() override;

#endif

DECLARE_VIRTUAL_TRACE();

// PluginPlaceholder methods

- virtual void loadIntoContainer(ContainerNode&) override;

+ void loadIntoContainer(ContainerNode&) override;

// Visible for testing.

WebPluginPlaceholder* webPluginPlaceholder() const { return m_webPluginPlaceholder.get(); }