Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: Source/web/WebSocketChannelClientProxy.h

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/WebSettingsImpl.h ('k') | Source/web/WebSocketImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebSocketChannelClientProxy_h 5 #ifndef WebSocketChannelClientProxy_h
6 #define WebSocketChannelClientProxy_h 6 #define WebSocketChannelClientProxy_h
7 7
8 #include "modules/websockets/WebSocketChannelClient.h" 8 #include "modules/websockets/WebSocketChannelClient.h"
9 #include "platform/heap/Handle.h" 9 #include "platform/heap/Handle.h"
10 #include "web/WebSocketImpl.h" 10 #include "web/WebSocketImpl.h"
(...skipping 10 matching lines...) Expand all
21 // heap. Thus we need to introduce a proxy class to decouple WebSocketImpl 21 // heap. Thus we need to introduce a proxy class to decouple WebSocketImpl
22 // from WebSocketChannelClient. 22 // from WebSocketChannelClient.
23 class WebSocketChannelClientProxy final : public GarbageCollectedFinalized<WebSo cketChannelClientProxy>, public WebSocketChannelClient { 23 class WebSocketChannelClientProxy final : public GarbageCollectedFinalized<WebSo cketChannelClientProxy>, public WebSocketChannelClient {
24 USING_GARBAGE_COLLECTED_MIXIN(WebSocketChannelClientProxy) 24 USING_GARBAGE_COLLECTED_MIXIN(WebSocketChannelClientProxy)
25 public: 25 public:
26 static WebSocketChannelClientProxy* create(WebSocketImpl* impl) 26 static WebSocketChannelClientProxy* create(WebSocketImpl* impl)
27 { 27 {
28 return new WebSocketChannelClientProxy(impl); 28 return new WebSocketChannelClientProxy(impl);
29 } 29 }
30 30
31 virtual void didConnect(const String& subprotocol, const String& extensions) override 31 void didConnect(const String& subprotocol, const String& extensions) overrid e
32 { 32 {
33 m_impl->didConnect(subprotocol, extensions); 33 m_impl->didConnect(subprotocol, extensions);
34 } 34 }
35 virtual void didReceiveTextMessage(const String& payload) override 35 void didReceiveTextMessage(const String& payload) override
36 { 36 {
37 m_impl->didReceiveTextMessage(payload); 37 m_impl->didReceiveTextMessage(payload);
38 } 38 }
39 virtual void didReceiveBinaryMessage(PassOwnPtr<Vector<char>> payload) overr ide 39 void didReceiveBinaryMessage(PassOwnPtr<Vector<char>> payload) override
40 { 40 {
41 m_impl->didReceiveBinaryMessage(payload); 41 m_impl->didReceiveBinaryMessage(payload);
42 } 42 }
43 virtual void didError() override 43 void didError() override
44 { 44 {
45 m_impl->didError(); 45 m_impl->didError();
46 } 46 }
47 virtual void didConsumeBufferedAmount(uint64_t consumed) override 47 void didConsumeBufferedAmount(uint64_t consumed) override
48 { 48 {
49 m_impl->didConsumeBufferedAmount(consumed); 49 m_impl->didConsumeBufferedAmount(consumed);
50 } 50 }
51 virtual void didStartClosingHandshake() override 51 void didStartClosingHandshake() override
52 { 52 {
53 m_impl->didStartClosingHandshake(); 53 m_impl->didStartClosingHandshake();
54 } 54 }
55 virtual void didClose(ClosingHandshakeCompletionStatus status, unsigned shor t code, const String& reason) override 55 void didClose(ClosingHandshakeCompletionStatus status, unsigned short code, const String& reason) override
56 { 56 {
57 WebSocketImpl* impl = m_impl; 57 WebSocketImpl* impl = m_impl;
58 m_impl = nullptr; 58 m_impl = nullptr;
59 impl->didClose(status, code, reason); 59 impl->didClose(status, code, reason);
60 } 60 }
61 61
62 DEFINE_INLINE_VIRTUAL_TRACE() 62 DEFINE_INLINE_VIRTUAL_TRACE()
63 { 63 {
64 WebSocketChannelClient::trace(visitor); 64 WebSocketChannelClient::trace(visitor);
65 } 65 }
66 66
67 private: 67 private:
68 explicit WebSocketChannelClientProxy(WebSocketImpl* impl) 68 explicit WebSocketChannelClientProxy(WebSocketImpl* impl)
69 : m_impl(impl) 69 : m_impl(impl)
70 { 70 {
71 } 71 }
72 72
73 WebSocketImpl* m_impl; 73 WebSocketImpl* m_impl;
74 }; 74 };
75 75
76 } // namespace blink 76 } // namespace blink
77 77
78 #endif // WebSocketChannelClientProxy_h 78 #endif // WebSocketChannelClientProxy_h
OLDNEW
« no previous file with comments | « Source/web/WebSettingsImpl.h ('k') | Source/web/WebSocketImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698