Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/RemoteFrameClientImpl.h ('k') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ServiceWorkerGlobalScopeClientImpl.h
diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/Source/web/ServiceWorkerGlobalScopeClientImpl.h
index 140639b04f9fdee928e660dd0d24021471328f41..931a65107e1ddf116786820d03774f4462029c4c 100644
--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.h
+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.h
@@ -46,29 +46,29 @@ class ServiceWorkerGlobalScopeClientImpl final : public NoBaseWillBeGarbageColle
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ServiceWorkerGlobalScopeClientImpl);
public:
static PassOwnPtrWillBeRawPtr<ServiceWorkerGlobalScopeClient> create(WebServiceWorkerContextClient&);
- virtual ~ServiceWorkerGlobalScopeClientImpl();
+ ~ServiceWorkerGlobalScopeClientImpl() override;
- virtual void getClients(const WebServiceWorkerClientQueryOptions&, WebServiceWorkerClientsCallbacks*) override;
- virtual void openWindow(const WebURL&, WebServiceWorkerClientCallbacks*) override;
- virtual void setCachedMetadata(const WebURL&, const char*, size_t) override;
- virtual void clearCachedMetadata(const WebURL&) override;
+ void getClients(const WebServiceWorkerClientQueryOptions&, WebServiceWorkerClientsCallbacks*) override;
+ void openWindow(const WebURL&, WebServiceWorkerClientCallbacks*) override;
+ void setCachedMetadata(const WebURL&, const char*, size_t) override;
+ void clearCachedMetadata(const WebURL&) override;
- virtual WebURL scope() const override;
+ WebURL scope() const override;
- virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult) override;
- virtual void didHandleFetchEvent(int fetchEventID) override;
- virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) override;
- virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) override;
- virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) override;
- virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) override;
- virtual void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult) override;
- virtual void didHandleCrossOriginConnectEvent(int connectEventID, bool acceptConnect) override;
- virtual void postMessageToClient(const WebString& clientUUID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;
- virtual void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;
- virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) override;
- virtual void claim(WebServiceWorkerClientsClaimCallbacks*) override;
- virtual void focus(const WebString& clientUUID, WebServiceWorkerClientCallbacks*) override;
- virtual void stashMessagePort(WebMessagePortChannel*, const WebString& name) override;
+ void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult) override;
+ void didHandleFetchEvent(int fetchEventID) override;
+ void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) override;
+ void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) override;
+ void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) override;
+ void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) override;
+ void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult) override;
+ void didHandleCrossOriginConnectEvent(int connectEventID, bool acceptConnect) override;
+ void postMessageToClient(const WebString& clientUUID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;
+ void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;
+ void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) override;
+ void claim(WebServiceWorkerClientsClaimCallbacks*) override;
+ void focus(const WebString& clientUUID, WebServiceWorkerClientCallbacks*) override;
+ void stashMessagePort(WebMessagePortChannel*, const WebString& name) override;
DEFINE_INLINE_VIRTUAL_TRACE() { ServiceWorkerGlobalScopeClient::trace(visitor); }
« no previous file with comments | « Source/web/RemoteFrameClientImpl.h ('k') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698