Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2304)

Unified Diff: Source/web/ExternalPopupMenu.h

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ExternalDateTimeChooser.cpp ('k') | Source/web/ExternalPopupMenuTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ExternalPopupMenu.h
diff --git a/Source/web/ExternalPopupMenu.h b/Source/web/ExternalPopupMenu.h
index aab0667eaab92c06865b7ab2e626e3103d60276b..851d4a3c91a302abdf891843a0ad7bee7d008b0c 100644
--- a/Source/web/ExternalPopupMenu.h
+++ b/Source/web/ExternalPopupMenu.h
@@ -53,7 +53,7 @@ struct WebPopupMenuInfo;
class ExternalPopupMenu final : public PopupMenu, public WebExternalPopupMenuClient {
public:
ExternalPopupMenu(LocalFrame&, PopupMenuClient*, WebViewImpl&);
- virtual ~ExternalPopupMenu();
+ ~ExternalPopupMenu() override;
// Fills |info| with the popup menu information contained in the
// PopupMenuClient associated with this ExternalPopupMenu.
@@ -67,16 +67,16 @@ public:
private:
// PopupMenu methods:
- virtual void show(const FloatQuad& controlPosition, const IntSize&, int index) override;
- virtual void hide() override;
- virtual void updateFromElement() override;
- virtual void disconnectClient() override;
+ void show(const FloatQuad& controlPosition, const IntSize&, int index) override;
+ void hide() override;
+ void updateFromElement() override;
+ void disconnectClient() override;
// WebExternalPopupClient methods:
- virtual void didChangeSelection(int index) override;
- virtual void didAcceptIndex(int index) override;
- virtual void didAcceptIndices(const WebVector<int>& indices) override;
- virtual void didCancel() override;
+ void didChangeSelection(int index) override;
+ void didAcceptIndex(int index) override;
+ void didAcceptIndices(const WebVector<int>& indices) override;
+ void didCancel() override;
void dispatchEvent(Timer<ExternalPopupMenu>*);
« no previous file with comments | « Source/web/ExternalDateTimeChooser.cpp ('k') | Source/web/ExternalPopupMenuTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698