Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | Source/web/SharedWorkerRepositoryClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ServiceWorkerGlobalScopeProxy.h
diff --git a/Source/web/ServiceWorkerGlobalScopeProxy.h b/Source/web/ServiceWorkerGlobalScopeProxy.h
index 4f7ae786adcc7b359fc631b816c4c12ff46c6780..d737346fca66def540a4e8758a9f01619f7066b4 100644
--- a/Source/web/ServiceWorkerGlobalScopeProxy.h
+++ b/Source/web/ServiceWorkerGlobalScopeProxy.h
@@ -65,32 +65,32 @@ class ServiceWorkerGlobalScopeProxy final
WTF_MAKE_NONCOPYABLE(ServiceWorkerGlobalScopeProxy);
public:
static PassOwnPtr<ServiceWorkerGlobalScopeProxy> create(WebEmbeddedWorkerImpl&, Document&, WebServiceWorkerContextClient&);
- virtual ~ServiceWorkerGlobalScopeProxy();
+ ~ServiceWorkerGlobalScopeProxy() override;
// WebServiceWorkerContextProxy overrides:
- virtual void setRegistration(WebServiceWorkerRegistration*) override;
- virtual void dispatchActivateEvent(int) override;
- virtual void dispatchCrossOriginConnectEvent(int, const WebCrossOriginServiceWorkerClient&) override;
- virtual void dispatchCrossOriginMessageEvent(const WebCrossOriginServiceWorkerClient&, const WebString& message, const WebMessagePortChannelArray&) override;
- virtual void dispatchFetchEvent(int, const WebServiceWorkerRequest&) override;
- virtual void dispatchGeofencingEvent(int, WebGeofencingEventType, const WebString& regionID, const WebCircularGeofencingRegion&) override;
- virtual void dispatchInstallEvent(int) override;
- virtual void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray&) override;
- virtual void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&) override;
- virtual void dispatchPushEvent(int, const WebString& data) override;
- virtual void dispatchSyncEvent(int) override;
- virtual void addStashedMessagePorts(const WebMessagePortChannelArray&, const WebVector<WebString>& webChannelNames) override;
+ void setRegistration(WebServiceWorkerRegistration*) override;
+ void dispatchActivateEvent(int) override;
+ void dispatchCrossOriginConnectEvent(int, const WebCrossOriginServiceWorkerClient&) override;
+ void dispatchCrossOriginMessageEvent(const WebCrossOriginServiceWorkerClient&, const WebString& message, const WebMessagePortChannelArray&) override;
+ void dispatchFetchEvent(int, const WebServiceWorkerRequest&) override;
+ void dispatchGeofencingEvent(int, WebGeofencingEventType, const WebString& regionID, const WebCircularGeofencingRegion&) override;
+ void dispatchInstallEvent(int) override;
+ void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray&) override;
+ void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&) override;
+ void dispatchPushEvent(int, const WebString& data) override;
+ void dispatchSyncEvent(int) override;
+ void addStashedMessagePorts(const WebMessagePortChannelArray&, const WebVector<WebString>& webChannelNames) override;
// WorkerReportingProxy overrides:
- virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;
- virtual void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;
- virtual void postMessageToPageInspector(const String&) override;
- virtual void postWorkerConsoleAgentEnabled() override { }
- virtual void didEvaluateWorkerScript(bool success) override;
- virtual void workerGlobalScopeStarted(WorkerGlobalScope*) override;
- virtual void workerGlobalScopeClosed() override;
- virtual void willDestroyWorkerGlobalScope() override;
- virtual void workerThreadTerminated() override;
+ void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;
+ void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;
+ void postMessageToPageInspector(const String&) override;
+ void postWorkerConsoleAgentEnabled() override { }
+ void didEvaluateWorkerScript(bool success) override;
+ void workerGlobalScopeStarted(WorkerGlobalScope*) override;
+ void workerGlobalScopeClosed() override;
+ void willDestroyWorkerGlobalScope() override;
+ void workerThreadTerminated() override;
private:
ServiceWorkerGlobalScopeProxy(WebEmbeddedWorkerImpl&, Document&, WebServiceWorkerContextClient&);
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | Source/web/SharedWorkerRepositoryClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698