Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 1230533002: Fix virtual/override/final usage in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebLocalFrameImpl.h ('k') | Source/web/WebMediaPlayerClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebLocalFrameImpl.cpp
diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp
index 83c7facdd0b39f3cd8b006cd991852932ae4caa6..f2f27e96a06ecc697ab89372ba735b4cae9248d3 100644
--- a/Source/web/WebLocalFrameImpl.cpp
+++ b/Source/web/WebLocalFrameImpl.cpp
@@ -336,7 +336,7 @@ public:
{
}
- virtual ~ChromePrintContext() { }
+ ~ChromePrintContext() override {}
virtual void begin(float width, float height)
{
@@ -486,30 +486,30 @@ public:
{
}
- virtual ~ChromePluginPrintContext() { }
+ ~ChromePluginPrintContext() override {}
- virtual void begin(float width, float height) override
+ void begin(float width, float height) override
{
}
- virtual void end() override
+ void end() override
{
m_plugin->printEnd();
}
- virtual float getPageShrink(int pageNumber) const override
+ float getPageShrink(int pageNumber) const override
{
// We don't shrink the page (maybe we should ask the widget ??)
return 1.0;
}
- virtual void computePageRects(const FloatRect& printRect, float headerHeight, float footerHeight, float userScaleFactor, float& outPageHeight) override
+ void computePageRects(const FloatRect& printRect, float headerHeight, float footerHeight, float userScaleFactor, float& outPageHeight) override
{
m_printParams.printContentArea = IntRect(printRect);
m_pageRects.fill(IntRect(printRect), m_plugin->printBegin(m_printParams));
}
- virtual void computePageRectsWithPageSize(const FloatSize& pageSizeInPixels) override
+ void computePageRectsWithPageSize(const FloatSize& pageSizeInPixels) override
{
ASSERT_NOT_REACHED();
}
@@ -518,7 +518,7 @@ protected:
// Spools the printed page, a subrect of frame(). Skip the scale step.
// NativeTheme doesn't play well with scaling. Scaling is done browser side
// instead. Returns the scale to be applied.
- virtual float spoolPage(GraphicsContext& context, int pageNumber) override
+ float spoolPage(GraphicsContext& context, int pageNumber) override
{
IntRect pageRect = m_pageRects[pageNumber];
m_plugin->printPage(pageNumber, &context, pageRect);
« no previous file with comments | « Source/web/WebLocalFrameImpl.h ('k') | Source/web/WebMediaPlayerClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698