|
Implement app banner info bars on desktop.
This CL extends the app banner implementation to work on desktop,
enabled with the flag --enable-add-to-shelf. With this flag active,
users will be prompted with an infobar to add a site to their shelf
once they have engaged with it to some substantive amount (subject to
heuristics currently implemented for the mobile add to homescreen
banner).
Note: the icon used is a placeholder to be updated later.
BUG= 491001
Committed: https://crrev.com/4d15cab83cf46e1e5b90b30541911c108b20c8d6
Cr-Commit-Position: refs/heads/master@{#332988}
Total comments: 33
Total comments: 1
Total comments: 12
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+498 lines, -72 lines) |
Patch |
|
M |
chrome/app/generated_resources.grd
|
View
|
1
2
3
4
5
|
1 chunk |
+11 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/app/theme/theme_resources.grd
|
View
|
1
2
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/android/banners/app_banner_data_fetcher_android.h
|
View
|
1
2
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/android/banners/app_banner_data_fetcher_android.cc
|
View
|
1
2
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
|
View
|
1
2
3
|
3 chunks |
+8 lines, -29 lines |
0 comments
|
Download
|
|
M |
chrome/browser/banners/app_banner_data_fetcher.h
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/banners/app_banner_data_fetcher.cc
|
View
|
1
2
3
4
5
6
7
|
4 chunks |
+3 lines, -21 lines |
0 comments
|
Download
|
|
M |
chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
A |
chrome/browser/banners/app_banner_data_fetcher_desktop.h
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/banners/app_banner_data_fetcher_desktop.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+84 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/banners/app_banner_infobar_delegate_desktop.h
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+73 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
|
View
|
1
2
3
4
|
1 chunk |
+101 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/banners/app_banner_manager.h
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/banners/app_banner_manager.cc
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
A |
chrome/browser/banners/app_banner_manager_desktop.h
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+32 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/banners/app_banner_manager_desktop.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+32 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/banners/app_banner_settings_helper.h
|
View
|
1
2
3
4
|
2 chunks |
+17 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/banners/app_banner_settings_helper.cc
|
View
|
1
2
|
2 chunks |
+41 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/bookmark_app_helper.h
|
View
|
1
2
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/bookmark_app_helper.cc
|
View
|
1
2
3
4
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/tab_helpers.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_browser.gypi
|
View
|
1
2
3
4
5
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
Total messages: 24 (4 generated)
|