Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration
Patch Set: Moving feature enabling to existing #ifs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | chrome/browser/banners/app_banner_manager_desktop.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index fdbf80b17677caf4fe6eeca51a5d479730fdffaf..dd3615d7c47fe25355a4d3a6ddfa439acaf7fdce 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -34,6 +34,14 @@ AppBannerManager::AppBannerManager(int icon_size)
weak_factory_(this) {
}
+AppBannerManager::AppBannerManager(content::WebContents* web_contents,
+ int icon_size)
+ : content::WebContentsObserver(web_contents),
+ ideal_icon_size_(icon_size),
+ data_fetcher_(nullptr),
+ weak_factory_(this) {
+}
+
AppBannerManager::~AppBannerManager() {
CancelActiveFetcher();
}
@@ -63,7 +71,6 @@ void AppBannerManager::DidFinishLoad(
data_fetcher_->Start(validated_url);
}
-
bool AppBannerManager::HandleNonWebApp(const std::string& platform,
const GURL& url,
const std::string& id) {
@@ -76,13 +83,6 @@ void AppBannerManager::ReplaceWebContents(content::WebContents* web_contents) {
data_fetcher_.get()->ReplaceWebContents(web_contents);
}
-AppBannerDataFetcher* AppBannerManager::CreateAppBannerDataFetcher(
- base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
- const int ideal_icon_size) {
- return new AppBannerDataFetcher(web_contents(), weak_delegate,
- ideal_icon_size);
-}
-
void AppBannerManager::CancelActiveFetcher() {
if (data_fetcher_ != nullptr) {
data_fetcher_->Cancel();
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | chrome/browser/banners/app_banner_manager_desktop.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698