Implement app banner info bars on desktop.

chrome/browser/banners/app_banner_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_manager.h"
 
 #include "base/metrics/field_trial.h"
 #include "chrome/browser/banners/app_banner_data_fetcher.h"
 #include "chrome/browser/banners/app_banner_debug_log.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "content/public/common/origin_util.h"
 #include "net/base/load_flags.h"
 #include "ui/gfx/screen.h"
 
 namespace {
 bool gDisableSecureCheckForTesting = false;
+
+// Used for non-mobile platforms.
+int kMinimumIconSize = 144;

[benwells, 2015/06/02 05:53:35]

Can we use the extension icon constant? At some point (i.e. you can log a TODO
for now) we should insist on whatever the set of icons is that will guarantee
the best user experience.

[dominickn (DO NOT USE), 2015/06/02 06:51:32]

The extensions code isn't compiled on Android, so this will either need compile
guards or an AppBannerManagerDesktop.

+
 }  // anonymous namespace
 
+DEFINE_WEB_CONTENTS_USER_DATA_KEY(banners::AppBannerManager);
+
 namespace banners {
 
 bool AppBannerManager::URLsAreForTheSamePage(const GURL& first,
                                              const GURL& second) {
   return first.GetWithEmptyPath() == second.GetWithEmptyPath() &&
          first.path() == second.path() && first.query() == second.query();
 }
 
 AppBannerManager::AppBannerManager(int icon_size)
     : ideal_icon_size_(icon_size),
       data_fetcher_(nullptr),
       weak_factory_(this) {
 }
 
+AppBannerManager::AppBannerManager(content::WebContents* web_contents)
+    : content::WebContentsObserver(web_contents),
+      ideal_icon_size_(kMinimumIconSize),
+      data_fetcher_(nullptr),
+      weak_factory_(this) {
+}
+
 AppBannerManager::~AppBannerManager() {
   CancelActiveFetcher();
 }
 
 void AppBannerManager::DidFinishLoad(
     content::RenderFrameHost* render_frame_host,
     const GURL& validated_url) {
   if (render_frame_host->GetParent())
     return;
 
   if (data_fetcher_.get() && data_fetcher_->is_active() &&
       URLsAreForTheSamePage(data_fetcher_->validated_url(), validated_url)) {
     return;
   }
 
   // A secure origin is required to show banners, so exit early if we see the
   // URL is invalid.
   if (!content::IsOriginSecure(validated_url) &&
       !gDisableSecureCheckForTesting) {
     OutputDeveloperNotShownMessage(web_contents(), kNotServedFromSecureOrigin);
     return;
   }
 
   // Kick off the data retrieval pipeline.
   data_fetcher_ = CreateAppBannerDataFetcher(weak_factory_.GetWeakPtr(),
                                              ideal_icon_size_);
   data_fetcher_->Start(validated_url);
 }
 
-
 bool AppBannerManager::HandleNonWebApp(const std::string& platform,
                                        const GURL& url,
                                        const std::string& id) {
   return false;
 }
 
 void AppBannerManager::ReplaceWebContents(content::WebContents* web_contents) {
   Observe(web_contents);
   if (data_fetcher_.get())
     data_fetcher_.get()->ReplaceWebContents(web_contents);
@@ skipping 19 matching lines @@
 
 void AppBannerManager::DisableSecureSchemeCheckForTesting() {
   gDisableSecureCheckForTesting = true;
 }
 
 bool AppBannerManager::IsEnabled() {
   return base::FieldTrialList::FindFullName("AppBanners") == "Enabled";
 }
 
 }  // namespace banners