Implement app banner info bars on desktop.

chrome/browser/banners/app_banner_settings_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
+#include "chrome/browser/banners/app_banner_data_fetcher.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/render_messages.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/content_settings/core/common/content_settings_pattern.h"
+#include "components/rappor/rappor_utils.h"
+#include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "net/base/escape.h"
 #include "url/gurl.h"
 
 namespace {
 
 // Max number of apps (including ServiceWorker based web apps) that a particular
 // site may show a banner for.
 const size_t kMaxAppsPerSite = 3;
 
@@ skipping 62 matching lines @@
     if (!pattern.IsValid())
       continue;
 
     settings->SetWebsiteSetting(pattern, ContentSettingsPattern::Wildcard(),
                                 CONTENT_SETTINGS_TYPE_APP_BANNER, std::string(),
                                 nullptr);
     settings->FlushLossyWebsiteSettings();
   }
 }
 
+void AppBannerSettingsHelper::RecordBannerWebInstallEvent(
+    content::WebContents* web_contents,
+    const std::string& package_name_or_start_url,
+    const std::string& rappor_metric,
+    int event_request_id_) {
+  banners::TrackInstallEvent(banners::INSTALL_EVENT_WEB_APP_INSTALLED);
+
+  web_contents->GetMainFrame()->Send(

[benwells, 2015/06/02 05:53:36]

The role of this helper is getting a bit haphazard. I am OK with it also doing
metrics, as it is a natural central point that everything goes through, but it
shouldn't be sending the outcome to the renderer. That feels too far out of its
role of helping out with settings.

About the metrics, if this class is going to encapsulate the metrics, it would
be great to have it define the rappor metrics we use. That is, instead of
passing in rappor_metric, pass in an enum WEB or NATIVE (or PLAY or ANDROID) and
use the correct rappor metric based on that.

[dominickn (DO NOT USE), 2015/06/02 06:51:32]

In progress.

+      new ChromeViewMsg_AppBannerAccepted(
+          web_contents->GetMainFrame()->GetRoutingID(),
+          event_request_id_, "web"));
+
+  AppBannerSettingsHelper::RecordBannerEvent(
+      web_contents, web_contents->GetURL(),
+      package_name_or_start_url,
+      AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
+      banners::AppBannerDataFetcher::GetCurrentTime());
+
+  rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
+                                          rappor_metric,
+                                          web_contents->GetURL());
+}
+
+void AppBannerSettingsHelper::RecordBannerDismissEvent(
+    content::WebContents* web_contents,
+    const std::string& package_name_or_start_url,
+    const std::string& rappor_metric,
+    int event_request_id_) {
+  banners::TrackDismissEvent(banners::DISMISS_EVENT_CLOSE_BUTTON);
+
+  web_contents->GetMainFrame()->Send(
+      new ChromeViewMsg_AppBannerDismissed(
+          web_contents->GetMainFrame()->GetRoutingID(),
+          event_request_id_));
+
+  AppBannerSettingsHelper::RecordBannerEvent(
+      web_contents, web_contents->GetURL(),
+      package_name_or_start_url,
+      AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK,
+      banners::AppBannerDataFetcher::GetCurrentTime());
+
+  rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
+                                          rappor_metric,
+                                          web_contents->GetURL());
+}
+
 void AppBannerSettingsHelper::RecordBannerEvent(
     content::WebContents* web_contents,
     const GURL& origin_url,
     const std::string& package_name_or_start_url,
     AppBannerEvent event,
     base::Time time) {
   Profile* profile =
       Profile::FromBrowserContext(web_contents->GetBrowserContext());
   if (profile->IsOffTheRecord() || package_name_or_start_url.empty())
     return;
@@ skipping 186 matching lines @@
   if (!app_dict)
     return base::Time();
 
   std::string event_key(kBannerEventKeys[event]);
   double internal_time;
   if (!app_dict->GetDouble(event_key, &internal_time))
     return base::Time();
 
   return base::Time::FromInternalValue(internal_time);
 }