Implement app banner info bars on desktop.

chrome/browser/banners/app_banner_infobar_delegate.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_BANNERS_APP_BANNER_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_BANNERS_APP_BANNER_INFOBAR_DELEGATE_H_
+
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"

[benwells, 2015/06/02 05:53:35]

Is weak_ptr used?

[dominickn (DO NOT USE), 2015/06/02 06:51:32]

Done.

+#include "base/strings/string16.h"
+#include "components/infobars/core/confirm_infobar_delegate.h"
+#include "content/public/common/manifest.h"
+#include "url/gurl.h"

[benwells, 2015/06/02 05:53:35]

Is gurl used?

[dominickn (DO NOT USE), 2015/06/02 06:51:32]

Done.

+
+class InfoBarService;

[benwells, 2015/06/02 05:53:35]

This doesn't appear to be used either.

[dominickn (DO NOT USE), 2015/06/02 06:51:32]

Done.

+
+namespace content {
+class WebContents;
+}  // namespace content
+
+namespace extensions {
+class BookmarkAppHelper;
+class Extension;
+}  // namespace extensions
+
+namespace infobars {
+class InfoBar;
+}  // namespace infobars
+
+namespace banners {
+
+class AppBannerDataFetcher;
+
+class AppBannerInfoBarDelegate : public ConfirmInfoBarDelegate {

[benwells, 2015/06/02 05:53:35]

Can we make this AppBannerInfoBarDelegateDesktop (with matching .h / .cc)?

[dominickn (DO NOT USE), 2015/06/02 06:51:32]

I feel like this should be connected to the decision regarding a desktop app
banner data fetcher - if that adds a desktop version, then this should too.

+
+ public:
+  ~AppBannerInfoBarDelegate() override;
+
+  static infobars::InfoBar* Create(
+      scoped_refptr<AppBannerDataFetcher> fetcher,
+      content::WebContents* web_contents,
+      const content::Manifest& web_app_data,

[benwells, 2015/06/02 05:53:35]

We should call this web_manifest. web_app_data makes me think it is a
WebApplicationData.

[dominickn (DO NOT USE), 2015/06/02 06:51:32]

Done.

+      extensions::BookmarkAppHelper* bookmark_app_helper,
+      int event_request_id);
+
+  // ConfirmInfoBarDelegate overrides.
+  base::string16 GetMessageText() const override;
+  base::string16 GetButtonLabel(InfoBarButton button) const override;
+
+  bool Accept() override;
+  bool Cancel() override;
+
+  // InfoBarDelegate override.
+  void InfoBarDismissed() override;
+
+ protected:
+  AppBannerInfoBarDelegate(scoped_refptr<AppBannerDataFetcher> fetcher,

[benwells, 2015/06/02 05:53:35]

Is there a reason this is protected, not private?

[dominickn (DO NOT USE), 2015/06/02 06:51:32]

It was in case the delegate needed to be further subclassed, e.g. for a mac
implementation.

+                           const content::Manifest& web_app_data,
+                           extensions::BookmarkAppHelper* bookmark_app_helper,
+                           int event_request_id);
+
+ private:
+  scoped_refptr<AppBannerDataFetcher> fetcher_;
+  content::Manifest web_app_data_;
+  extensions::BookmarkAppHelper* bookmark_app_helper_;
+  int event_request_id_;
+
+  Type GetInfoBarType() const override;
+  int GetIconID() const override;
+};
+
+}  // namespace banners
+
+#endif  // CHROME_BROWSER_BANNERS_APP_BANNER_INFOBAR_DELEGATE_H_