Implement app banner info bars on desktop.

chrome/browser/extensions/bookmark_app_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/bookmark_app_helper.h"
 
 #include <cctype>
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 473 matching lines @@
   callback_ = callback;
 
   if (contents_) {
     contents_->GetManifest(base::Bind(&BookmarkAppHelper::OnDidGetManifest,
                                      base::Unretained(this)));
   } else {
     OnIconsDownloaded(true, std::map<GURL, std::vector<SkBitmap> >());
   }
 }
 
+void BookmarkAppHelper::CreateFromAppBanner(
+    const CreateBookmarkAppCallback& callback,
+    const content::Manifest& manifest) {
+  callback_ = callback;
+  OnDidGetManifest(manifest);

[benwells, 2015/06/02 05:53:36]

We should have some dchecks to make sure the manifest has all the stuff we need,
as the web_app_data will be empty for this code path.

[dominickn (DO NOT USE), 2015/06/02 06:51:33]

In progress.

+}
+
 void BookmarkAppHelper::OnDidGetManifest(const content::Manifest& manifest) {
   if (contents_->IsBeingDestroyed())
     return;
 
   UpdateWebAppInfoFromManifest(manifest, &web_app_info_);
 
   // Add urls from the WebApplicationInfo.
   std::vector<GURL> web_app_info_icon_urls;
   for (std::vector<WebApplicationInfo::IconInfo>::const_iterator it =
            web_app_info_.icons.begin();
@@ skipping 53 matching lines @@
       ResizeIconsAndGenerateMissing(downloaded_icons, SizesToGenerate(),
                                     &web_app_info_);
   ReplaceWebAppIcons(size_to_icons, &web_app_info_);
   favicon_downloader_.reset();
 
   if (!contents_) {
     // The web contents can be null in tests.
     OnBubbleCompleted(true, web_app_info_);
     return;
   }
+  ShowBookmarkAppBubble();
+}
 
+void BookmarkAppHelper::ShowBookmarkAppBubble() {

[benwells, 2015/06/02 05:53:36]

Is there a reason to split this out, or was it just for clarity?

[dominickn (DO NOT USE), 2015/06/02 06:51:33]

It was initially necessary, but is now just for clarity and can be factored back
in.

   Browser* browser = chrome::FindBrowserWithWebContents(contents_);
   if (!browser) {
     // The browser can be null in tests.
     OnBubbleCompleted(true, web_app_info_);
     return;
   }
+
   browser->window()->ShowBookmarkAppBubble(
       web_app_info_, base::Bind(&BookmarkAppHelper::OnBubbleCompleted,
                                 base::Unretained(this)));
 }
 
 void BookmarkAppHelper::OnBubbleCompleted(
     bool user_accepted,
     const WebApplicationInfo& web_app_info) {
   if (user_accepted) {
     web_app_info_ = web_app_info;
@@ skipping 136 matching lines @@
       extension, info_list, base::Bind(&OnIconsLoaded, web_app_info, callback));
 }
 
 bool IsValidBookmarkAppUrl(const GURL& url) {
   URLPattern origin_only_pattern(Extension::kValidWebExtentSchemes);
   origin_only_pattern.SetMatchAllURLs(true);
   return url.is_valid() && origin_only_pattern.MatchesURL(url);
 }
 
 }  // namespace extensions