Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration
Patch Set: Moving feature enabling to existing #ifs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index 1f813242879c6000e896cd80715077c2529c2370..f908db90547cf92c2b1b1796cdb15a9eaf3ebd00 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -11,6 +11,7 @@
#include "base/observer_list.h"
#include "base/time/time.h"
#include "chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h"
+#include "chrome/common/web_application_info.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/common/manifest.h"
@@ -115,8 +116,8 @@ class AppBannerDataFetcher
bool FetchIcon(const GURL& image_url);
// Creates a banner for the app using the given |icon|.
- virtual infobars::InfoBar* CreateBanner(const SkBitmap* icon,
- const base::string16& title);
+ virtual void ShowBanner(const SkBitmap* icon,
+ const base::string16& title) = 0;
// Records that a banner was shown. The |event_name| corresponds to the RAPPOR
// metric being recorded.
@@ -129,7 +130,7 @@ class AppBannerDataFetcher
void OnFetchComplete(const GURL& url, const SkBitmap* icon) override;
// Shows a banner for the app, if the given |icon| is valid.
- virtual void ShowBanner(const SkBitmap* icon);
+ virtual void RequestShowBanner(const SkBitmap* icon);
// Record that the banner could be shown at this point, if the triggering
// heuristic allowed.

Powered by Google App Engine
This is Rietveld 408576698