Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/extensions/bookmark_app_helper.cc

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration
Patch Set: Moving feature enabling to existing #ifs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/bookmark_app_helper.cc
diff --git a/chrome/browser/extensions/bookmark_app_helper.cc b/chrome/browser/extensions/bookmark_app_helper.cc
index 93afdf6eda13a102ef7235937f32de9babd309a4..c15e0de0e6f38a0abd1369b060f0b647c54598e8 100644
--- a/chrome/browser/extensions/bookmark_app_helper.cc
+++ b/chrome/browser/extensions/bookmark_app_helper.cc
@@ -491,6 +491,16 @@ void BookmarkAppHelper::Create(const CreateBookmarkAppCallback& callback) {
}
}
+void BookmarkAppHelper::CreateFromAppBanner(
+ const CreateBookmarkAppCallback& callback,
+ const content::Manifest& manifest) {
+ DCHECK(!manifest.short_name.is_null() || !manifest.name.is_null());
+ DCHECK(manifest.start_url.is_valid());
+
+ callback_ = callback;
+ OnDidGetManifest(manifest);
+}
+
void BookmarkAppHelper::OnDidGetManifest(const content::Manifest& manifest) {
if (contents_->IsBeingDestroyed())
return;
« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698