Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3241)

Unified Diff: chrome/browser/banners/app_banner_settings_helper.h

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration
Patch Set: Moving feature enabling to existing #ifs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_settings_helper.h
diff --git a/chrome/browser/banners/app_banner_settings_helper.h b/chrome/browser/banners/app_banner_settings_helper.h
index 8e0e971589ad75acc3160e7f25492d1eaf555671..b71802110e5e5a191c9b656414dbf4e464ee940f 100644
--- a/chrome/browser/banners/app_banner_settings_helper.h
+++ b/chrome/browser/banners/app_banner_settings_helper.h
@@ -46,6 +46,11 @@ class AppBannerSettingsHelper {
APP_BANNER_EVENT_NUM_EVENTS,
};
+ enum AppBannerRapporMetric {
+ WEB,
+ NATIVE,
+ };
+
// The content setting basically records a simplified subset of history.
// For privacy reasons this needs to be cleared. The ClearHistoryForURLs
// function removes any information from the banner content settings for the
@@ -53,6 +58,18 @@ class AppBannerSettingsHelper {
static void ClearHistoryForURLs(Profile* profile,
const std::set<GURL>& origin_urls);
+ // Record a banner installation event, for either a WEB or NATIVE app.
+ static void RecordBannerInstallEvent(
+ content::WebContents* web_contents,
+ const std::string& package_name_or_start_url,
+ AppBannerRapporMetric rappor_metric);
+
+ // Record a banner dismissal event, for either a WEB or NATIVE app.
+ static void RecordBannerDismissEvent(
+ content::WebContents* web_contents,
+ const std::string& package_name_or_start_url,
+ AppBannerRapporMetric rappor_metric);
+
static void RecordBannerEvent(content::WebContents* web_contents,
const GURL& origin_url,
const std::string& package_name_or_start_url,
« no previous file with comments | « chrome/browser/banners/app_banner_manager_desktop.cc ('k') | chrome/browser/banners/app_banner_settings_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698