Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration
Patch Set: Moving feature enabling to existing #ifs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
index ac212f5c090be252bbc202058e293d4a1613023b..84a883f2b99d69356145d2367a4b24e1465e7a85 100644
--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
@@ -155,33 +155,18 @@ void AppBannerInfoBarDelegateAndroid::InfoBarDismissed() {
if (!web_contents)
return;
- TrackDismissEvent(DISMISS_EVENT_CLOSE_BUTTON);
-
web_contents->GetMainFrame()->Send(
new ChromeViewMsg_AppBannerDismissed(
web_contents->GetMainFrame()->GetRoutingID(),
event_request_id_));
if (!native_app_data_.is_null()) {
- AppBannerSettingsHelper::RecordBannerEvent(
- web_contents, web_contents->GetURL(),
- native_app_package_,
- AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK,
- AppBannerDataFetcher::GetCurrentTime());
-
- rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
- "AppBanner.NativeApp.Dismissed",
- web_contents->GetURL());
+ AppBannerSettingsHelper::RecordBannerDismissEvent(
+ web_contents, native_app_package_, AppBannerSettingsHelper::NATIVE);
} else if (!web_app_data_.IsEmpty()) {
- AppBannerSettingsHelper::RecordBannerEvent(
- web_contents, web_contents->GetURL(),
- web_app_data_.start_url.spec(),
- AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK,
- AppBannerDataFetcher::GetCurrentTime());
-
- rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
- "AppBanner.WebApp.Dismissed",
- web_contents->GetURL());
+ AppBannerSettingsHelper::RecordBannerDismissEvent(
+ web_contents, web_app_data_.start_url.spec(),
+ AppBannerSettingsHelper::WEB);
}
}
@@ -224,11 +209,9 @@ bool AppBannerInfoBarDelegateAndroid::Accept() {
SendBannerAccepted(web_contents, "play");
return was_opened;
} else if (!web_app_data_.IsEmpty()) {
- AppBannerSettingsHelper::RecordBannerEvent(
- web_contents, web_contents->GetURL(),
- web_app_data_.start_url.spec(),
- AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
- AppBannerDataFetcher::GetCurrentTime());
+ AppBannerSettingsHelper::RecordBannerInstallEvent(
+ web_contents, web_app_data_.start_url.spec(),
+ AppBannerSettingsHelper::WEB);
ShortcutInfo info;
info.UpdateFromManifest(web_app_data_);
@@ -239,11 +222,7 @@ bool AppBannerInfoBarDelegateAndroid::Accept() {
info,
*app_icon_.get()));
- TrackInstallEvent(INSTALL_EVENT_WEB_APP_INSTALLED);
SendBannerAccepted(web_contents, "web");
- rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
- "AppBanner.WebApp.Installed",
- web_contents->GetURL());
return true;
}
« no previous file with comments | « chrome/browser/android/banners/app_banner_data_fetcher_android.cc ('k') | chrome/browser/banners/app_banner_data_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698