cc: Move cc/quads/list_container.* files to cc/base.

cc: Move cc/quads/list_container.* files to cc/base.

This change moves the list_container.* files from cc/quads to cc/base
as these gets used in cc/quads as well as cc/playback.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;tryserver.blink:linux_blink_rel

[prashant.n, 2015-05-23 13:04:01]

prashant.n@samsung.com changed reviewers:
+ brianderson@chromium.org, danakj@chromium.org, enne@chromium.org

[prashant.n, 2015-05-23 13:04:01]

Due to moving list_container.h and .cc file to cc/base, the template
definitions done for SharedQuadState, DrawQuad, DisplayItem needs to
be moved to render_pass.cc and display_item_list.cc. As these are
template definitions, it needs the list_container.cc file to be
included into render_pass.cc and display_item_list.cc files. Pls.
check if this is acceptable or not.

I also renamed the list_container_unittests.cc to
quad_list_container_unittests.cc as this file contains unit tests
related to quads' classes only.

PTAL

[enne (OOO), 2015-05-26 18:31:28]

https://codereview.chromium.org/1159573002/diff/1/cc/playback/display_item_li...
File cc/playback/display_item_list.cc (right):

https://codereview.chromium.org/1159573002/diff/1/cc/playback/display_item_li...
cc/playback/display_item_list.cc:11: #include "cc/base/list_container.cc"
Don't include cc files, please.  Find some other way to do this.

https://codereview.chromium.org/1159573002/diff/1/cc/quads/quad_list_containe...
File cc/quads/quad_list_container_unittest.cc (right):

https://codereview.chromium.org/1159573002/diff/1/cc/quads/quad_list_containe...
cc/quads/quad_list_container_unittest.cc:71: TEST(QuadListContainerTest,
ConstructorCalledInAllocateAndConstruct) {
I think these are really testing the list container, but happen to be using
quads.  So, I think this file and test names should stay as they were before.

[prashant.n, 2015-05-26 19:11:48]

Please check the queries I've.

https://codereview.chromium.org/1159573002/diff/1/cc/playback/display_item_li...
File cc/playback/display_item_list.cc (right):

https://codereview.chromium.org/1159573002/diff/1/cc/playback/display_item_li...
cc/playback/display_item_list.cc:11: #include "cc/base/list_container.cc"
We'll have to then merge then list_container.h and list_container.cc. If it is
okay I'll modify accordingly in next patch set.

https://codereview.chromium.org/1159573002/diff/1/cc/quads/quad_list_containe...
File cc/quads/quad_list_container_unittest.cc (right):

https://codereview.chromium.org/1159573002/diff/1/cc/quads/quad_list_containe...
cc/quads/quad_list_container_unittest.cc:71: TEST(QuadListContainerTest,
ConstructorCalledInAllocateAndConstruct) {
Ok I can revert this. But again problem comes, as per chromium practice, we
cannot place the unit test file adjacent to the file i.e. list_container.cc.

So is it okay placing unit test file in quads folder OR we create simple mock
class which uses list container and place it in cc/base and modify the unit test
file accordingly to test list container and then place unit test also in
cc/base?

[prashant.n, 2015-05-27 17:05:30]

Still working on moving list_container_unittest.cc to cc/base.

[enne (OOO), 2015-05-28 17:19:54]

On 2015/05/27 at 17:05:30, prashant.n wrote:
> Still working on moving list_container_unittest.cc to cc/base.

[enne (OOO), 2015-05-28 17:20:03]

You need to add list_container.cc to this patch set.

You don't have to merge all of list_container.cc into list_container.h.  You can
put the non-templated stuff in the .cc file, and then include the header.  It's
a templated class, so it's not unexpected that the header is large if it wants
to be used generally.

If you can't include quads from cc/base, then list_container_unittest.cc should
be changed to be based on some mock class.  I don't think it makes sense to test
list container in cc/quads.

[prashant.n, 2015-05-29 04:41:56]

On 2015/05/28 17:20:03, enne wrote:
> You need to add list_container.cc to this patch set.
> 
> You don't have to merge all of list_container.cc into list_container.h.  You
can
> put the non-templated stuff in the .cc file, and then include the header. 
It's
> a templated class, so it's not unexpected that the header is large if it wants
> to be used generally.

Yes.
> 
> If you can't include quads from cc/base, then list_container_unittest.cc
should
> be changed to be based on some mock class.  I don't think it makes sense to
test
> list container in cc/quads.

I'll put the CL for this if jbroman is not working on this.

[prashant.n, 2017-09-06 13:57:41]

Description was changed from

==========
cc: Move cc/quads/list_container.* files to cc/base.

This change moves the list_container.* files from cc/quads to cc/base
as these gets used in cc/quads as well as cc/playback.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move cc/quads/list_container.* files to cc/base.

This change moves the list_container.* files from cc/quads to cc/base
as these gets used in cc/quads as well as cc/playback.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;tryserver.blink:linux_blink_rel
==========

[prashant.n, 2017-09-06 14:00:31]

Patchset #3 (id:40001) has been deleted