Description1. With introduction of compressed formats, e.g. ETC1, the number of
bits per pixel is becoming less than 8. Computing bytes per pixel by
BitsPerPixel(format) / 8, might give different values. So compute the
bits per row first and divide it by 8 to get the bytes per row.
2. Move resource size computation functions to separate file,
i.e. resource_util.cc.
3. Move resource format related functions to resource_format.h. As
there is dependecy on third_party/khronos/GLES2/gl2.h &
third_party/khronos/GLES2/gl2ext.h, the inlined functions have been
written as non-inlined functions and header files have been included
in resource_format.cc.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/8e4942838460a8d66a31c46baf265a5a8b61a16a
Cr-Commit-Position: refs/heads/master@{#341492}
Patch Set 1 #Patch Set 2 : int=size_t in video_resource_updater.cc. #Patch Set 3 : row bytes aligned #
Total comments: 7
Patch Set 4 : Moving few functions to their own files. #
Total comments: 1
Patch Set 5 : Formatted. #Patch Set 6 : Formatted. #Patch Set 7 : RowSize=>Width. #
Total comments: 5
Patch Set 8 : Corrected function names. #Patch Set 9 : Corrected comments. #
Total comments: 7
Patch Set 10 : Addressed review comments. #
Total comments: 3
Patch Set 11 : Addressed review comments. #
Total comments: 6
Patch Set 12 : Templatized all the functions for consistency. #Patch Set 13 : Removed resource_util.cc. #Patch Set 14 : Removed redundant static_assert. #Patch Set 15 : Fixed issue. #Patch Set 16 : Ensured bytes to be integral value. #
Total comments: 7
Patch Set 17 : Added unit test for resource_util functions. #Patch Set 18 : Removed constness of height. #Patch Set 19 : Addressed review comments. #Patch Set 20 : Spelling mistake. #
Total comments: 1
Patch Set 21 : Replaced std::is_same by local definition. #Patch Set 22 : Rebased. #Patch Set 23 : Rebase errors. #Patch Set 24 : Rebase errors. #Patch Set 25 : Fixed win build break. #Patch Set 26 : Fixed Android build break. #
Created: 5 years, 4 months ago
Depends on Patchset: Messages
Total messages: 62 (19 generated)
|