Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2067213002: cc: Implement tile iteration order based on pyramid sequence. [old]

Created:
4 years, 6 months ago by prashant.n
Modified:
3 years, 10 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tiling_data_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Implement tile iteration order based on pyramid sequence. This patch implements pyramid sequence for getting tile indices from closer to farther or farther to closer fashion. The pyramid sequence iterates level by level, i.e. inner level to outer level and vice versa. This is used to implement SpiralDifferenceIterator and ReverseSpiralDifferenceIterator. The pyramid sequence takes width and height of the tile into consideration, giving better order of tiles over previous version. This patch also adds support for move assignment and move constructor, so that objects can be in-place constructed and moved to desired container. This patch also adds test for the tiling smaller than tile size and center rect not intersecting to tiling rect. BUG=613695 TESTS=TilingDataTest.SpiralDifferenceIteratorWideTiles* CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;tryserver.blink:linux_blink_rel

Patch Set 1 #

Patch Set 2 : tild #

Total comments: 15

Patch Set 3 : tild #

Patch Set 4 : tild #

Patch Set 5 : backup #

Patch Set 6 : backup #

Patch Set 7 : backup #

Patch Set 8 : backup #

Patch Set 9 : backup #

Patch Set 10 : backup #

Patch Set 11 : backup #

Patch Set 12 : backup #

Patch Set 13 : backup #

Patch Set 14 : backup #

Patch Set 15 : backup #

Patch Set 16 : backup #

Patch Set 17 : backup #

Patch Set 18 : backup #

Patch Set 19 : backup #

Patch Set 20 : backup #

Patch Set 21 : backup #

Patch Set 22 : unit tests working #

Patch Set 23 : backup #

Patch Set 24 : backup #

Patch Set 25 : backup #

Patch Set 26 : backup #

Patch Set 27 : backup #

Patch Set 28 : backup #

Patch Set 29 : backup #

Patch Set 30 : backup #

Patch Set 31 : backup #

Patch Set 32 : clockwise seq #

Patch Set 33 : ready for initial review #

Patch Set 34 : backup #

Patch Set 35 : unittests updated #

Patch Set 36 : backup #

Patch Set 37 : for review #

Total comments: 10

Patch Set 38 : backup #

Patch Set 39 : backup #

Patch Set 40 : review comments #

Patch Set 41 : rebase #

Patch Set 42 : fixed broken test #

Patch Set 43 : updated comments in code - coverage direction #

Patch Set 44 : spiral coverage sequence #

Total comments: 7

Patch Set 45 : backup #

Patch Set 46 : backup #

Patch Set 47 : backup w/o affinity #

Patch Set 48 : backup affinity #

Patch Set 49 : backup affinity #

Patch Set 50 : backup affinity #

Patch Set 51 : backup affinity #

Patch Set 52 : backup affinity #

Patch Set 53 : backup affinity #

Patch Set 54 : backup affinity #

Patch Set 55 : backup affinity #

Patch Set 56 : backup affinity ok #

Patch Set 57 : backup affinity cr #

Patch Set 58 : backup affinity ncr ok #

Patch Set 59 : backup unittests almost #

Patch Set 60 : backup #

Patch Set 61 : backup #

Patch Set 62 : backup #

Patch Set 63 : backup #

Patch Set 64 : backup #

Patch Set 65 : backup f1 #

Patch Set 66 : backup #

Patch Set 67 : backup nc #

Patch Set 68 : backup #

Patch Set 69 : backup #

Patch Set 70 : backup fin #

Patch Set 71 : rebase #

Patch Set 72 : backup #

Patch Set 73 : try perf #

Patch Set 74 : test #

Patch Set 75 : rebase #

Patch Set 76 : backup #

Patch Set 77 : rebase -> used for smoothness tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2573 lines, -163 lines) Patch
M cc/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 1 chunk +2 lines, -0 lines 0 comments Download
M cc/base/index_rect.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +3 lines, -0 lines 0 comments Download
M cc/base/index_rect.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 2 chunks +8 lines, -0 lines 0 comments Download
A cc/base/pyramid_sequence.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 1 chunk +735 lines, -0 lines 0 comments Download
A cc/base/pyramid_sequence.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 1 chunk +1069 lines, -0 lines 0 comments Download
A + cc/base/pyramid_sequence_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 68 76 28 chunks +133 lines, -108 lines 0 comments Download
M cc/base/reverse_spiral_iterator.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 1 chunk +5 lines, -1 line 0 comments Download
M cc/base/reverse_spiral_iterator.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 1 chunk +14 lines, -0 lines 0 comments Download
M cc/base/spiral_iterator.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 1 chunk +5 lines, -1 line 0 comments Download
M cc/base/spiral_iterator.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 1 chunk +11 lines, -0 lines 0 comments Download
M cc/base/spiral_iterator_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 2 chunks +2 lines, -2 lines 0 comments Download
M cc/base/switches.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/switches.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 1 chunk +5 lines, -0 lines 0 comments Download
M cc/base/tiling_data.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 6 chunks +37 lines, -2 lines 0 comments Download
M cc/base/tiling_data.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 69 6 chunks +213 lines, -38 lines 0 comments Download
M cc/base/tiling_data_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 3 chunks +180 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 1 chunk +2 lines, -0 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 2 chunks +4 lines, -0 lines 0 comments Download
M cc/tiles/tiling_set_eviction_queue.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 6 chunks +42 lines, -0 lines 0 comments Download
M cc/tiles/tiling_set_eviction_queue.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 6 chunks +12 lines, -6 lines 0 comments Download
M cc/tiles/tiling_set_raster_queue_all.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 46 47 48 49 50 51 52 53 54 55 56 7 chunks +47 lines, -0 lines 0 comments Download
M cc/tiles/tiling_set_raster_queue_all.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 4 chunks +20 lines, -3 lines 0 comments Download
M cc/tiles/tiling_set_raster_queue_required.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 46 47 48 49 50 51 52 53 54 55 56 1 chunk +5 lines, -0 lines 0 comments Download
M cc/tiles/tiling_set_raster_queue_required.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 1 chunk +15 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 45 (16 generated)
prashant.n
Just have a look. Patch is not yet finished. I've been implementing this approach for ...
4 years, 6 months ago (2016-06-16 15:14:46 UTC) #3
vmpstr
I'm just reading through the code in terms of code itself. It's hard for me ...
4 years, 6 months ago (2016-06-16 18:28:58 UTC) #4
prashant.n
Once complete with all possible unittests added, I'll add more comments and a doc for ...
4 years, 6 months ago (2016-06-17 04:20:01 UTC) #5
prashant.n
I'm thinking of adding new iterator (something like SpiralDistanceDifferenceIterator) co-exist with current SpiralDifferenceIterator and once ...
4 years, 6 months ago (2016-06-17 14:20:48 UTC) #6
prashant.n
ptal @ initial version of new implementation. I've added explainatory comments. It now passes all ...
4 years, 5 months ago (2016-06-30 14:32:42 UTC) #8
prashant.n
Pls. wait for review until I finish the chrome working with patch.
4 years, 5 months ago (2016-07-08 13:49:27 UTC) #9
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 11:43:10 UTC) #14
prashant.n
+enne. vmpstr@ and enne@ I've finished implementing new logic. This works well with chrome and ...
4 years, 5 months ago (2016-07-18 11:49:11 UTC) #15
prashant.n
ptal patchset 37, few unit tests are breaking. I will be fixing them tomorrow.
4 years, 5 months ago (2016-07-19 12:46:32 UTC) #19
vmpstr
I just looked at the pyramid sequence. I think we can break that into two ...
4 years, 5 months ago (2016-07-19 20:28:28 UTC) #20
prashant.n
Thanks for the review comments. I'll write more illustrative comments with more intuitive function names ...
4 years, 5 months ago (2016-07-20 03:10:49 UTC) #21
prashant.n
https://codereview.chromium.org/2067213002/diff/720001/cc/base/pyramid_sequence.h File cc/base/pyramid_sequence.h (right): https://codereview.chromium.org/2067213002/diff/720001/cc/base/pyramid_sequence.h#newcode52 cc/base/pyramid_sequence.h:52: class CC_EXPORT TriangularSequence { > If that's the case, ...
4 years, 5 months ago (2016-07-20 03:53:10 UTC) #22
prashant.n
ptal.
4 years, 5 months ago (2016-07-25 12:27:28 UTC) #23
prashant.n
vmpstr@, with latest patchset following tests are failing where increasing or decreasing distances are considered. ...
4 years, 4 months ago (2016-07-28 13:10:20 UTC) #24
vmpstr
On 2016/07/28 13:10:20, prashant.n wrote: > vmpstr@, with latest patchset following tests are failing where ...
4 years, 4 months ago (2016-07-28 18:50:57 UTC) #25
prashant.n
> The idea of the spiral iterator is to keep mostly increasing distances except on ...
4 years, 4 months ago (2016-07-29 02:13:13 UTC) #26
prashant.n
The newer implementation is spiral but with precedence.
4 years, 4 months ago (2016-07-29 02:27:09 UTC) #27
prashant.n
TL T TR L * R BL B BR where - R = right TR ...
4 years, 4 months ago (2016-07-29 02:45:50 UTC) #28
prashant.n
For the test PictureLayerImplTest.TilingSetEvictionQueue, the layout of tiling for eviction order is given below. Note ...
4 years, 4 months ago (2016-07-29 03:05:44 UTC) #29
prashant.n
ping. vmpstr@ can you pls. comment on this?
4 years, 4 months ago (2016-08-01 21:20:06 UTC) #30
prashant.n
vmpstr@, can you pls. review this further?
4 years, 4 months ago (2016-08-09 04:31:26 UTC) #31
vmpstr
On 2016/07/29 02:13:13, prashant.n wrote: > > The idea of the spiral iterator is to ...
4 years, 4 months ago (2016-08-09 18:55:59 UTC) #32
prashant.n
> I don't necessarily agree that this gives better coverage. Both approaches are > fairly ...
4 years, 4 months ago (2016-08-10 01:11:41 UTC) #33
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 4 months ago (2016-08-10 11:01:31 UTC) #36
vmpstr
On 2016/08/10 01:11:41, prashant.n wrote: > > I don't necessarily agree that this gives better ...
4 years, 4 months ago (2016-08-10 20:45:41 UTC) #40
prashant.n
> Yeah I think it would be nice if we have a patch that doesn't ...
4 years, 4 months ago (2016-08-11 02:11:39 UTC) #41
prashant.n
> If the user is scrolling to the right, then the skewport would start at ...
4 years, 4 months ago (2016-08-12 01:38:15 UTC) #42
vmpstr
This code seems too complicated for what we want.. Can we step back and come ...
4 years, 4 months ago (2016-08-16 00:40:48 UTC) #43
prashant.n
4 years, 1 month ago (2016-11-08 11:53:49 UTC) #44

          

Powered by Google App Engine
This is Rietveld 408576698